Repository navigation
Conversation
When a user ran `fenn pull <bad-name> ...` for a non-existent template, the error pointed to `fenn pull --list`, a flag that does not exist on the pull subcommand. Point to the real command, `fenn list`, instead. Adds regression assertions to test_pull_template_not_found to lock in the correct hint and prevent reintroducing the non-existent flag.
0eab867 to
714e347
Compare
|
Hey @rusetiq! Thx 4 your work Kindly check why pipeline fails |
|
sure! give me a while, i'll work on it and commit |
|
im pretty sure thatd fix it! |
|
@ApusBerliozi fixed! |
|
Hey @rusetiq! Thx I think, there are way to more changes in files for such an error. I will comeback with full report once I have some free time |
63dd422 to
57a1b00
Compare
|
Thanks for flagging the scope issue. I audited and reduced the PR from 12 files (+709/-144) to 3 files (+17/-13). Removed from this PR:
The branch now contains only the original CLI fix and regression assertions, plus the 12 mechanical Updated in commit |
|
@ApusBerliozi mind checking? |
| if np.max(alpha_channel) > 1.0: | ||
| normalized_alpha = 2.0 * (alpha_channel / 255.0) - 1.0 |
There was a problem hiding this comment.
Could you please elaborate, why we need to add changes here?
There was a problem hiding this comment.
Hey @ApusBerliozi, sorry for the long delay getting back to you, and thanks for reviewing!
I included the changes in normalize.py because the pipeline was failing on ty diagnostics for the NumPy .max() / .min() method calls. Switching them to np.max(...) / np.min(...) cleared those diagnostics without intentionally changing the normalization behavior.
They aren't needed for the CLI hint fix itself; I added them to get the checks passing. I understand the concern about keeping this PR focused and am happy to move them into a separate PR if you'd prefer. Thanks for your patience!
|
Hey @rusetiq! Sorry 4 taking so long, was busy. Kindly check review comment |
Summary
Fixes #312.
When a user ran
fenn pull <bad-name> ...for a template that does not exist, the CLI suggestedfenn pull --list. That flag does not exist on thepullsubcommand. The correct command for listing templates isfenn list.Changes
fenn/cli/pull.py: point the template-not-found hint tofenn list.tests/unit/cli/test_pull_command.py: add regression assertions for the corrected hint.fenn/experimental/vision/normalize.py: replace 12 equivalent NumPy bound-method reductions (array.max()/array.min()) withnp.max(array)/np.min(array). These mechanical substitutions resolve thetydiagnostics that caused the PR pipeline to fail; no normalization behavior is intentionally changed.Scope
The PR is limited to 3 files with 17 additions and 13 deletions. Unrelated dashboard, template-test, normalization-validation, warning-handling, and lockfile changes have been removed.
Verification
pre-commit run --all-files: passedReproduction
Run
fenn pull DOES_NOT_EXIST temp.Expected: the response suggests
fenn list.Previously observed: the response suggested the nonexistent
fenn pull --listcommand.