Eliminate Workaround for Sensitive Data; require puppetlabs/concat 7.4; require puppet 7.9#607
Open
cocker-cc wants to merge 1 commit into
Open
Conversation
cocker-cc
force-pushed
the
Eliminate_Workarounds_for_Sensitive
branch
from
May 10, 2024 12:17
408c244 to
3d5f40b
Compare
bastelfreak
changed the title
bastelfreak
previously approved these changes
May 10, 2024
cocker-cc
force-pushed
the
Eliminate_Workarounds_for_Sensitive
branch
from
June 13, 2024 19:40
3d5f40b to
014bce0
Compare
|
Hey @cocker-cc, sorry for the long delay in following up with this. This PR looks good to me. Two small things: there seems to be some conflicts to be resolved; and the puppet minimum version bump is currently a regression. If you could adjust those, I'll be happy to kick off tests and move forward with this. |
"concat" handles sensitive Data since 7.4.0. "empty" in Puppet-Core handles sensitive Data since Puppet 7.9.0. So the Workarounds for Sensitive Data can be elminiated. fixes 4287df8
cocker-cc
force-pushed
the
Eliminate_Workarounds_for_Sensitive
branch
from
July 21, 2026 15:25
014bce0 to
9df9822
Compare
|
One last thing. Title no longer reflects accurately the changes. If you could adjust it. I'll be happy to review and merge. |
Author
How would you rephrase it, or to put it another way: what's wrong with the Wording? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Eliminate Workaround for Sensitive Data
Additional Context
"concat" handles sensitive Data since 7.4.0.
"empty" in Puppet-Core handles sensitive Data since Puppet 7.9.0.
Related Issues (if any)
fixes 4287df8
Checklist
pdk validatepdk test unit