Embed only the CSS each HTML page needs - #26
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors HTML generation to emit page-specific embedded CSS, aiming to reduce per-page CSS payload by selecting only the styles required for each generated HTML page type.
Changes:
- Introduces
HtmlPageKindand threads it throughGenerateTemplateHtml/label page generation to identify which page is being rendered. - Replaces monolithic CSS generation with segmented CSS blocks and a
GetCssStyle(pageKind)selector to embed only the necessary CSS per page. - Updates index, daily, and label pages to pass the correct
HtmlPageKindso each page gets the intended stylesheet subset.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.