fix: use promtool for listenLocal health probes - #8672
Open
SebTardif wants to merge 3 commits into
Open
Conversation
heliapb
reviewed
Jul 6, 2026
simonpasquier
left a comment
simonpasquier
left a comment
Contributor
There was a problem hiding this comment.
We need to check the Prometheus version because promtool check healthy|ready was added in 2.44.0.
simonpasquier
left a comment
simonpasquier
left a comment
Contributor
There was a problem hiding this comment.
Ideally we'd need an end-to-end test validating the 2 scenarios
- busybox image with
listenLocal: true - distroless image with
listenLocal: true
Distroless Prometheus images lack sh/curl/wget, so exec probes built with a shell wrapper always fail when listenLocal is true. Probe with promtool check healthy/ready against localhost instead. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Satisfy modernize/stringscut (golangci-lint) as noted in review. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
Restore shell-based ExecAction for config-reloader and pre-2.44 Prometheus, add PromtoolExecAction for distroless Prometheus images, and gate promtool on version 2.44.0+. Cover both packaging styles in e2e. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
SebTardif
force-pushed
the
fix/listenlocal-promtool-probes
branch
from
July 15, 2026 14:50
05c75f1 to
1fe5a12
Compare
Contributor
Author
Done in 1fe5a12.
Added
Also:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When
listenLocal: true, probes usedsh -cwithcurl/wget. Distroless images (default in kube-prometheus-stack) do not include those tools, so readiness/liveness fail permanently.Fix
Use
promtool check healthy|ready --url=http://localhost:9090for listenLocal probes.promtoolships in official Prometheus images.Testing
go test ./pkg/operator/ -run TestProbersstatefulset_test.goRef #8605