Repository navigation
feat(server): add NetBIOS & DNS names - #1471
Merged
Merged
Conversation
[...] to the challenge target information so client can build NTLMv2 responses. Handle each authentication exchange independently with a 30-second timeout so interrupted or malformed attempts do not block later clients. Cancel pending exchanges and wait for capture workers on shutdown. Validate Type 3 messages before formatting hashes and remove captured hashes from debug logs. Preserve capture before authentication rejection. Also migrate goimpocket imports from from github.com/Mzack9999/goimpacket to github.com/projectdiscovery/goimpacket Fixes #1469 Closes #1470 Signed-off-by: Dwi Siswanto <git@dw1.io>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Mzack9999
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(server): add NetBIOS & DNS names
[...] to the challenge target information so client can build NTLMv2
responses.
Handle each authentication exchange independently with a 30-second
timeout so interrupted or malformed attempts do not block later
clients. Cancel pending exchanges and wait for capture workers on
shutdown.
Validate Type 3 messages before formatting hashes and remove captured
hashes from debug logs. Preserve capture before authentication
rejection.
Also migrate goimpocket imports from from
github.com/Mzack9999/goimpacket to
github.com/projectdiscovery/goimpacket
Fixes #1469
Closes #1470