Skip to content

feat(server): add NetBIOS & DNS names - #1471

Merged
dwisiswant0 merged 1 commit into
devfrom
dwisiswant0/feat/server/add-NetBIOS-DNS-names
Oct 6, 2026
Merged

dwisiswant0 merged 1 commit into
devfrom
dwisiswant0/feat/server/add-NetBIOS-DNS-names

Conversation

@dwisiswant0

Copy link
Copy Markdown
Member

feat(server): add NetBIOS & DNS names

[...] to the challenge target information so client can build NTLMv2
responses.

Handle each authentication exchange independently with a 30-second
timeout so interrupted or malformed attempts do not block later
clients. Cancel pending exchanges and wait for capture workers on
shutdown.

Validate Type 3 messages before formatting hashes and remove captured
hashes from debug logs. Preserve capture before authentication
rejection.

Also migrate goimpocket imports from from
github.com/Mzack9999/goimpacket to
github.com/projectdiscovery/goimpacket

Fixes #1469
Closes #1470

[...] to the challenge target information so client can build NTLMv2
responses.

Handle each authentication exchange independently with a 30-second
timeout so interrupted or malformed attempts do not block later
clients. Cancel pending exchanges and wait for capture workers on
shutdown.

Validate Type 3 messages before formatting hashes and remove captured
hashes from debug logs. Preserve capture before authentication
rejection.

Also migrate goimpocket imports from from
github.com/Mzack9999/goimpacket to
github.com/projectdiscovery/goimpacket

Fixes #1469
Closes #1470

Signed-off-by: Dwi Siswanto <git@dw1.io>
@dwisiswant0
dwisiswant0 requested a review from Mzack9999 October 5, 2026 18:21
@coderabbitai

coderabbitai Bot commented Oct 5, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 00a7fab6-c674-4da2-a77c-fabd48d71e93

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@dwisiswant0
dwisiswant0 merged commit 42f81ef into dev Oct 6, 2026
9 checks passed
@dwisiswant0
dwisiswant0 deleted the dwisiswant0/feat/server/add-NetBIOS-DNS-names branch October 6, 2026 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants