Repository navigation
docs(skills): capture merge-queue, consumer-CI, and Renovate learnings - #402
Merged
Merged
Conversation
Documents the non-obvious behaviours discovered while wiring up the
Renovate/MergeRaptor auto-merge path, so future agents do not rediscover
them by trial and error.
- AGENTS.md: `main` is merge-queue governed. `gh pr merge` exits 0 on all
three enqueue paths (explicit strategy warning, already-queued warning,
and silent queue-strategy merge), so the outcome must be confirmed with
`gh pr view --json state` rather than inferred from exit code or stderr.
- consumer-validation.md: a draft PR in projectbluefin/bluefin produces no
CI run at all, so the protocol's required run URL is unobtainable until
`gh pr ready` is run. Reconciled the step-1 wording, the API recipe, and
the AGENTS.md summary, which all still said "draft".
- factory-operations.md: added a Verification checklist for the auto-merge
path. The branch-protection bypass and the caller workflow are
independent halves; configuring only one leaves the system inert while
looking correctly configured, which is exactly how this regressed.
- composite-actions.md: recorded that `helpers:pinGitHubActionDigests` is
`{matchDepTypes:["action"], pinDigests:true}` and that reusable workflow
refs are also depType `action`, plus why the disabling rule must be last
(`applyPackageRules` merges in order; last matching rule wins).
Verified against Context7 /renovatebot/renovate and cited in frontmatter.
- SKILL.md: routing entries for the three new sections.
Assisted-by: Claude Opus 5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.Scanned FilesNone |
The consumer-validation check exempts PRs that touch no consumer-facing
action files, logging "No consumer-facing action changes detected;
skipping" before the URL format rules are evaluated. Neither AGENTS.md
nor the skill file mentioned this, so the documented rule ("N/A is only
accepted for Out-of-org consumer impact") appeared to contradict the
observed behaviour on docs-only PRs.
Clarified that the exemption is path-based and decided by the workflow,
so writing "N/A" in the body does not grant it.
Assisted-by: Claude Opus 5 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
hanthor
approved these changes
Aug 16, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
Docs-only, reviewed the full diff. The additions are internally consistent and each cross-referenced claim checks out:
- AGENTS.md's merge-queue gotcha (exit 0 on all three enqueue paths, confirm via
gh pr view --json state) matches the described consumer PRs. - The draft-PR-produces-no-CI note is applied consistently across AGENTS.md,
consumer-validation.md(steps 1/2, the API recipe withgh pr ready, and the "Even for internal-only workflows" section), so there's no stale text pointing back at "open a draft consumer PR" as sufficient on its own. - The
helpers:pinGitHubActionDigestsrule and the "last-matching-rule-wins"applyPackageRulesexplanation incomposite-actions.mdare precise and match documented Renovate behavior, with the Context7 source cited. docs/SKILL.mdrouting table additions point at real new sections that exist in the diff.- Path-based exemption text in
consumer-validation.mdmatches this very PR's evidence (docs-only, N/A accepted).
All 3 checks green (secret-reference check, dependency review, consumer-validation-evidence check — correctly self-exempted as docs-only). No workflow/action files touched, so no consumer-impact concerns.
Generated by Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs-only. Writes back the non-obvious behaviours discovered while wiring up the Renovate/MergeRaptor auto-merge path, per the skill-improvement mandate.
What changed
AGENTS.mdmainis merge-queue governed;gh pr mergeexits 0 on all three enqueue paths. Confirm withgh pr view --json state.docs/skills/consumer-validation.mdgh pr ready. Reconciled step 1, the API recipe, and the AGENTS.md summary.docs/skills/factory-operations.mddocs/skills/composite-actions.mdhelpers:pinGitHubActionDigestsis{matchDepTypes:["action"], pinDigests:true}, reusable workflow refs are also depTypeaction, and the disabling rule must be last becauseapplyPackageRulesmerges in order.docs/SKILL.mdContext7 verification
Renovate behaviour verified against
/renovatebot/renovate(lib/config/presets/internal/helpers.preset.ts,lib/util/package-rules/index.ts) rather than written from memory. Library ID recorded in the frontmatter of both skill files that cover it.Verification
pre-commit run --files <changed>— passed. No workflow or action files touched, so actionlint/floating-tag/consumer-contract hooks correctly skip.Consumer PR: N/A — docs-only, no action or workflow files changed, so no consumer behaviour is affected.
Consumer CI run: N/A — docs-only.
Out-of-org consumer impact: N/A
Assisted-by: Claude Opus 5 via GitHub Copilot