Fix GROMACS 2025 checkpoint notification ordering#1430
Open
DrDomenicoMarson wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Fix the ordering of checkpoint notifications in the GROMACS 2025 integration.
The existing checkpoint callback is delivered while GROMACS writes the checkpoint, after PLUMED has performed its calculation for that step. Consequently, actions such as
OPES_METADusingSTATE_WFILEwithoutSTATE_WSTRIDEcan write state data for a different step thanstate.cpt.I found the problem, and here I'm trying to propose a fix, with the help of a coding agent as my expertise ends with Python... If the fix is not good enough I hope the PR will raise awareness of the problem.
This change:
PlumedForceProviderbeforeperformCalc.No public PLUMED API or OPES behavior is changed.
Validation
Using GROMACS 2025.0 and checkpoint-only OPES state output:
0.044 ps, whilestate.cptwas at0.080 ps.md: both were at0.080 ps.md-vv: both were at0.080 ps.The regenerated directory-format patch was also checked for clean application and reversion. PLUMED and patched GROMACS builds, a serial OPES smoke test, and
git diff --checkpassed.This is a follow-up to #1428.
Target release
I would like my code to appear in release 2.10.1
Type of contribution
Copyright
Tests