Repository navigation
Fix jitterbuffer - #422
Merged
Merged
Fix jitterbuffer#422
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #422 +/- ##
==========================================
+ Coverage 85.62% 85.67% +0.04%
==========================================
Files 91 91
Lines 3986 3985 -1
==========================================
+ Hits 3413 3414 +1
+ Misses 573 571 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
thatsnotright
force-pushed
the
fix-jitterbuffer
branch
from
September 17, 2026 11:11
855d9ec to
7a77736
Compare
thatsnotright
force-pushed
the
fix-jitterbuffer
branch
from
September 27, 2026 19:38
7a77736 to
59e90fb
Compare
thatsnotright
force-pushed
the
fix-jitterbuffer
branch
from
September 27, 2026 20:20
bfcc4ac to
5d98d9b
Compare
thatsnotright
force-pushed
the
fix-jitterbuffer
branch
2 times, most recently
from
October 8, 2026 00:24
49ae44b to
bee58ab
Compare
thatsnotright
approved these changes
Oct 8, 2026
Critical defects addressed: 1. Circular list in Push Inserting a node with the same priority as the head previously created a bidirectional cycle (head.next = newPq && newPq.next = head), leading to infinite loops during Pop/Find. Rewrite the insertion logic to prevent circular references. 2. Missing prev/next pointer updates in Pop / PopAt / PopAtTimestamp Removal did not update adjacent nodes' prev/next pointers nor clear the removed node's pointers, resulting in dangling references and preventing timely GC. Add proper pointer re-linking and cleanup in all removal paths. 3. Memory leak in Clear Clear only set each node's prev to nil but left q.next pointing to the old head, keeping the entire node chain reachable and preventing GC. Fix by resetting q.next to nil so the chain becomes unreachable and collectible.
Initialize PriorityQueue and node pointer fields explicitly in NewQueue and newNode.
thatsnotright
force-pushed
the
fix-jitterbuffer
branch
from
October 8, 2026 00:27
bee58ab to
6723ee4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Inserting a node with the same priority as the head previously created a
bidirectional cycle (head.next = newPq && newPq.next = head), leading to
infinite loops during Pop/Find. Rewrite the insertion logic to prevent
circular references.
Missing prev/next pointer updates in Pop / PopAt / PopAtTimestamp
Removal did not update adjacent nodes' prev/next pointers nor clear the
removed node's pointers, resulting in dangling references and preventing
timely GC. Add proper pointer re-linking and cleanup in all removal paths.
3.Memory leak in Clear
Clear only set each node's prev to nil but left q.next pointing to the old
head, keeping the entire node chain reachable and preventing GC. Fix by
resetting q.next to nil so the chain becomes unreachable and collectible.
Reference issue
None