[diffs] Cache Key Cleanup - #1055
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5643fb2398
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
5643fb2 to
e457b19
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e7d029a7a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
e7d029a to
2de0a3d
Compare
otherwise you can get into bad scenarios where you combine 1 file with other files that don't have cache keys and you're fucked cause the cache keys will match but be incorrect
2de0a3d to
f237769
Compare
1 participant
(WIP) Essentially
cacheKeyswere incorrectly inherited from file names with the edit release, which breaks a lot of assumptions how how they should work.This PR is looking over that infrastructure to try and clean all that up and harden the system.