Add granular publish tags for "-bin" docker image#614
Conversation
|
@asgrim ✅ |
|
This fixed #480, right? However, I wonder if this implementation is entirely correct: for e.g. 1.5.0-alpha.1, this would now also update the Likely you'd want to distinguish stable and non-stable tags in some way, similar to how it's done for the floating |
yep |
I suppose similar guard can added there: ${{ ((!contains(github.ref, 'alpha') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc')) && 'type=raw,value=bin') || '' }} |
|
This also needs to be backported to 1.4.x branch? |
|
Besides the obvious bug with pre-release versions, I wonder what problem this is attempting to solve. Is there ever a good reason to intentionally stay on an outdated branch of PIE? |
|
Well, this is merged to 1.5, but there are no 1.5 releases. I'm new to pie, so i'm not aware when will be 1.5.0 is released, and i would like to update my Dockerfile to 1.x branch, be it 1.4 or 1.5, not really relevant to me. i'm assuming the project follows basic semver. |
Fix: It maybe not loking the nicest, it follows the same pattern, so should be easy to review |
Implement TODO:
pie/.github/workflows/release.yml
Lines 90 to 96 in 5c3fa89
See:
PR submitter checklist
I have added appropriate testsFuture TODO
After this is merged and verified working also update documentation (another PR):