Skip to content

Add granular publish tags for "-bin" docker image#614

Merged
asgrim merged 2 commits into
php:1.5.xfrom
glensc:patch-1
May 20, 2026
Merged

Add granular publish tags for "-bin" docker image#614
asgrim merged 2 commits into
php:1.5.xfrom
glensc:patch-1

Conversation

@glensc
Copy link
Copy Markdown
Contributor

@glensc glensc commented May 13, 2026

Implement TODO:

  • with:
    # @TODO v1.0 Consider introducing more granular tags (major and major.minor)
    # @see https://github.com/php/pie/pull/122#pullrequestreview-2477496308
    # @see https://github.com/php/pie/pull/122#discussion_r1867331273
    tags: |
    ${{ ((!contains(github.ref, 'alpha') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc')) && 'type=raw,value=bin') || '' }}
    type=semver,pattern={{version}},suffix=-bin

See:

PR submitter checklist

Future TODO

After this is merged and verified working also update documentation (another PR):

@asgrim
Copy link
Copy Markdown
Contributor

asgrim commented May 15, 2026

@glensc please can you complete the PR submitter checklist; you can reference #122 in the second checklist item

@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented May 19, 2026

@asgrim

@asgrim asgrim self-requested a review May 19, 2026 14:36
@asgrim asgrim added the enhancement New feature or request label May 19, 2026
@asgrim asgrim added this to the 1.5.0 milestone May 19, 2026
Comment thread .github/workflows/release.yml Outdated
@asgrim asgrim enabled auto-merge May 20, 2026 20:14
@asgrim asgrim merged commit c9e57c5 into php:1.5.x May 20, 2026
24 checks passed
@jnoordsij
Copy link
Copy Markdown
Contributor

This fixed #480, right?

However, I wonder if this implementation is entirely correct: for e.g. 1.5.0-alpha.1, this would now also update the 1-bin 'major' image if I understand things correctly.

Likely you'd want to distinguish stable and non-stable tags in some way, similar to how it's done for the floating bin tag.

@asgrim
Copy link
Copy Markdown
Contributor

asgrim commented May 26, 2026

This fixed #480, right?

However, I wonder if this implementation is entirely correct: for e.g. 1.5.0-alpha.1, this would now also update the 1-bin 'major' image if I understand things correctly.

Likely you'd want to distinguish stable and non-stable tags in some way, similar to how it's done for the floating bin tag.

yep

@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented May 27, 2026

This fixed #480, right?

However, I wonder if this implementation is entirely correct: for e.g. 1.5.0-alpha.1, this would now also update the 1-bin 'major' image if I understand things correctly.

Likely you'd want to distinguish stable and non-stable tags in some way, similar to how it's done for the floating bin tag.

I suppose similar guard can added there:

${{ ((!contains(github.ref, 'alpha') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc')) && 'type=raw,value=bin') || '' }}

@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented May 27, 2026

This also needs to be backported to 1.4.x branch?

@TimWolla
Copy link
Copy Markdown
Member

Besides the obvious bug with pre-release versions, I wonder what problem this is attempting to solve. Is there ever a good reason to intentionally stay on an outdated branch of PIE?

@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented May 27, 2026

Well, this is merged to 1.5, but there are no 1.5 releases.

I'm new to pie, so i'm not aware when will be 1.5.0 is released, and i would like to update my Dockerfile to 1.x branch, be it 1.4 or 1.5, not really relevant to me. i'm assuming the project follows basic semver.

@glensc
Copy link
Copy Markdown
Contributor Author

glensc commented May 27, 2026

This fixed #480, right?
However, I wonder if this implementation is entirely correct: for e.g. 1.5.0-alpha.1, this would now also update the 1-bin 'major' image if I understand things correctly.
Likely you'd want to distinguish stable and non-stable tags in some way, similar to how it's done for the floating bin tag.

I suppose similar guard can added there:

${{ ((!contains(github.ref, 'alpha') && !contains(github.ref, 'beta') && !contains(github.ref, 'rc')) && 'type=raw,value=bin') || '' }}

Fix:

It maybe not loking the nicest, it follows the same pattern, so should be easy to review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants