Repository navigation
[Bug]: weights_method argument not used in s_proportion_diff(). #1521
Description
Bug
weights_method argument is not used in s_proportion_diff().
See here:
Line 90 in 2eee1f7
I guess the correct specification of this argument should be weights_method = c("cmh", "wilson_h"). Then, the if-else clause below is no longer needed.
# Defining the std way to calculate weights for strat_newcombe
if (!is.null(variables$weights_method)) {
weights_method <- variables$weights_method
} else {
weights_method <- "cmh"
}Man page has incorrect information
The man page for the weights_method parameter in prop_diff_strat_nc() currently states:
@param weights_method (`string`)\cr weights method. Can be either `"cmh"` or `"heuristic"`
and directs the way weights are estimated.This is incorrect. Based on the implementation of prop_diff_strat_nc(), weights_method can be either "cmh" or "wilson_h".
Code of Conduct
- I agree to follow this project's Code of Conduct.
Contribution Guidelines
- I agree to follow this project's Contribution Guidelines.
Security Policy
- I agree to follow this project's Security Policy.
Activity
Solves issue pharmaverse#1521.
wwojciech commentedon Sep 10, 2026
It is resolved within PR #1515.
wwojciech commentedon Sep 10, 2026
Hi @danielinteractive , I resolved this issue within PR #1515 .
Can you pl. review if the solution is correct and I did not miss anything?
(I can also assign me to this issue).
Thank you!
Add new (helper) functions for proportions that prepares safe 2x2 con…
safe_2x2_table()helper #1514wwojciech commentedon Sep 19, 2026
Solved by PR #1515