Repository navigation
Conversation
…#865) run_maintenance() did timestamptz month arithmetic in the session timezone, so a partition set aligned to a non-UTC zone drifted when maintenance ran from a different session (e.g. a UTC client such as DataGrip): new boundaries and child names no longer landed on the intended day. The timezone a set is aligned to is now recorded at creation in the new part_config.partition_timezone column (overridable via p_timezone on create_parent/create_partition), and all boundary math is done in that timezone. A NULL value keeps the previous session-timezone behavior, so existing sets are unaffected until it is set. Adds an upgrade script and a pgTAP regression test.
x4m
marked this pull request as draft
July 17, 2026 06:04
Author
|
Still draft, not ready for review yet. Sorry for posting too early. |
x4m
marked this pull request as ready for review
July 20, 2026 16:46
Collaborator
|
I'm not sure I'm in favor of this feature quite yet. I've already documented how timezones are expected to work based on the client that runs the commands https://github.com/pgpartman/pg_partman/blob/development/doc/pg_partman.md#time-zones |
Author
|
Thanks for the pointer! I need to think about it. Should I close the PR so far, or let's keep it for a while? |
Collaborator
|
You can leave it open for now if you'd like in case there's an idea you come up with around it that you'd like to share. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
run_maintenance() did timestamptz month arithmetic in the session timezone, so a partition set aligned to a non-UTC zone drifted when maintenance ran from a different session (e.g. a UTC client such as DataGrip): new boundaries and child names no longer landed on the intended day.
The timezone a set is aligned to is now recorded at creation in the new part_config.partition_timezone column (overridable via p_timezone on create_parent/create_partition), and all boundary math is done in that timezone. A NULL value keeps the previous session-timezone behavior, so existing sets are unaffected until it is set. Adds an upgrade script and a pgTAP regression test.