Repository navigation
fix/menu dialog focus and node tests - #142
Merged
Merged
Conversation
Both menu items called preventDefault, which tells Radix to keep the menu open. It stayed behind the dialog, and closing the dialog left focus nowhere with the page unclickable until the menu was dismissed. #115 fixed the same thing for Delete. The menu assertion now includes hidden elements. An open dialog hides everything else from the accessibility tree, so the old check passed even while the menu was still open behind it.
Node 25+ has its own localStorage and sessionStorage globals that take over from jsdom's. localStorage is undefined without --localstorage-file, and neither is a jsdom Storage, so about 24 tests failed locally while CI, on the .nvmrc version, passed. The test setup now swaps in an in-memory Storage on those versions and leaves jsdom's alone everywhere else.
|
Strix is installed on this repository, but we couldn't run this PR security review because this workspace's trial has ended. Add a card to resume code reviews here. So far, Strix has reviewed 14 pull requests across this workspace. |
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit