Conversation
Integrates a new filesystem-family source that stages remote files via oc-rsync before handing them to the shared filesystem reader. Registers the `rsync://` (daemon) and `rsync+ssh://` (SSH) URI schemes, with full test coverage across transport, command building, staging, and end-to-end reads.
Address five findings from issue #262: - B1/B4: Normalise trailing slashes in remote_spec (transport.py) - B2: Guard empty pattern in filter_rules (command.py) - B6: Deduplicate query_params call (api.py) - S1: Allowlist validation for binary option (config.py) - S9: Restrict staging directory permissions to 0o700 (stager.py) Tighten docstrings across all rsync modules and tests to match current code after the fixes.
- Fix ruff I001 (unsorted imports) in api.py - Skip SubprocessRunner tests on Windows (shell scripts need POSIX) - Skip staging dir permissions test on Windows (NTFS has no mode bits)
Contributor
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About
Add connector for rsync. Thank you, @oferchen! 1
Details
References
Footnotes
I haven't been able to push to your fork, so I have staged a new PR hereby. ↩