fix(commerce): secondary enrichment for pages without JSON-LD (FIX-IF-04) - #108
Merged
Merged
Conversation
added 5 commits
September 22, 2026 08:44
Adds extract_price_from_html_patterns() as a structured fallback when JSON-LD/OpenGraph/microdata extraction finds no price. Targets known e-commerce HTML patterns (data-price attributes, price class spans, itemprop meta tags, currency symbols near digits in first 8KB). Key properties: - ONLY fires when primary extraction returns no price (fallback, not replacement) - ONLY sets price + currency — never merchant, rating, or other facts - Marked source="extracted_from_text" for provenance transparency - Rejects unreasonable prices (<=0 or >=10M) - Preserves structured currency symbols ($, €, £, ¥, ₹, Rs., INR, etc.) Verified: build clean, 9 new unit tests covering data-price, class spans, itemprop meta, currency preservation, fallback gating (does not fire when JSON-LD/microdata present), non-product pages, and unreasonable price rejection.
Pattern 4 (price text extraction) now requires a currency symbol AND a price-related class/data attribute. This prevents false positives from body text like "costs about $2" while preserving detection of product-price spans with currency symbols. Removed itemprop from pattern 4 (microdata parser handles those).
Contributor
|
Warning Review limit reachedNext included review available in 59 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (9)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lands FIX-IF-04 (card t_0c9b81ca). Secondary commerce enrichment for pages lacking JSON-LD. CI green on this branch.