AO3-7616 Fix Share widgets to hide username for anonymous works

[domvrk]

Pull Request Checklist

• Have you read the contributing guidelines?
• Have you read "How to write the perfect pull request"?
• Have you added tests for any changed functionality?
• Have you added the Jira issue number
  as the first thing in your pull request title (e.g. AO3-1234 Fix thing)
• Do you have fewer than 5 pull requests already open? If not, please wait
  until they are reviewed and merged before creating new pull requests.
• I acknowledge that submitting code created or modified with the help of AI is a bannable offense.

Issue

https://otwarchive.atlassian.net/browse/AO3-7616 (Please fill in issue number and remove this comment.)

Purpose

Fix Twitter and Tumblr Share Widgets to hide username if work is in anonymous collection for either Admin or Owner of the work.

Credit

domvrk (he/him)

Jira: Dominic M

[sarken]

Hi, domvrk!

Thank you so much for this pull request. I haven't reviewed the changes, but I wanted to note that the test failure looks like it's real. I'm going to put the Reviewed: Action Needed label on this for now to indicate it's not quite ready yet. Once you've got the tests passing, we'll switch it back to Awaiting Review.

In the meantime, I've updated the Jira issue status to In Review so no one mistakenly creates a duplicate pull request.

Unfortunately, Jira has been unreliable about showing us new accounts in the admin panel lately, and I can't find your account. If you can either reply here or send an email to otw-coders@transformativeworks.org with your account email address, we should be able to get that fixed and update your permissions.

Thanks again for contributing! If you have any questions, you can contact us at the same email address listed above.

[domvrk]

Jira Email: cinimod964@gmail.com

[sarken]

Thanks for addressing the test failure! I've set the label back to "Awaiting Review" and updated your Jira permissions. Everything should be set the next time you log in, but if you run into issues, you can let us know here or via email and we'll look into it.

[Bilka2]

Thanks for working on this! It looks like the visibility: "public" option already stops the creator name from showing for anonymous creations. What do you think about using that instead of adding a new option?

[domvrk]

Thanks for working on this! It looks like the visibility: "public" option already stops the creator name from showing for anonymous creations. What do you think about using that instead of adding a new option?

Whoops. Thought I saw a reason not to initially, but upon re-review it looks fine to use. Thanks!

[Bilka2]

Thanks for changing the option! I have some more review feedback, now more about the concrete code and tests