AO3-7565 On Fulfilled Claims page, "Fulfilled Claims" button doesn't appear pressed - #5966
AO3-7565 On Fulfilled Claims page, "Fulfilled Claims" button doesn't appear pressed#5966ScottVenkataraman wants to merge 4 commits into
Conversation
|
I believe the test failures are unrelated to changes I made in this PR. |
sarken
left a comment
There was a problem hiding this comment.
Thanks for working on this! It looks good to be, but since this is such a small change, I left some suggestions for other clean up -- we'd appreciate it if you could make those adjustments as well.
| @@ -6,10 +6,10 @@ | |||
| <% unless params[:for_user] %> | |||
| <ul class="navigation actions" role="navigation"> | |||
| <li id="unposted-link"> | |||
There was a problem hiding this comment.
Could you remove these two id attributes while you're here? We generally don't apply id attributes to things unless they're necessary for JavaScript or similar. (I have a feeling someone intended them for testing once upon a time, but they don't seem to be in use currently.)
There was a problem hiding this comment.
Should be easy enough!
| @@ -6,10 +6,10 @@ | |||
| <% unless params[:for_user] %> | |||
| <ul class="navigation actions" role="navigation"> | |||
There was a problem hiding this comment.
Could you remove the role here (it's invalid on ul elements) and fix the indenting? It should be just two spaces deeper than the unless, while the li elements should be two spaces deeper than the ul.
Pull Request Checklist
as the first thing in your pull request title (e.g.
AO3-1234 Fix thing)until they are reviewed and merged before creating new pull requests.
Issue
https://otwarchive.atlassian.net/browse/AO3-7565
Purpose
What does this PR do?
This PR makes the "fulfilled claims" button on the "claims" page appear selected when clicked.
Testing Instructions
How can the Archive's QA team verify that this is working as you intended?
You can follow the instructions from the Jira ticket for setup.
Once the "Fulfilled claims" button has been selected, add "&foo=bar" to the end of the url and press enter. If this is done without the changes added here, "Fulfilled Claims" appears unselected after the refresh. With these changes in place, the button remains selected after the refresh.
These instructions will be added to the Jira ticket
Credit
Scott Venkataraman he/him