Skip to content

chore(ci): Support key_management stable change. - #582

Merged
c-r33d merged 1 commit into
mainfrom
move-km-stable
Aug 19, 2026
Merged

chore(ci): Support key_management stable change.#582
c-r33d merged 1 commit into
mainfrom
move-km-stable

Conversation

@c-r33d

@c-r33d c-r33d commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

1.) Support new and old key_management flags

Tested with a manual run:

Summary by CodeRabbit

  • Bug Fixes
    • Improved key-management support detection by checking both standard and preview service configurations.
    • Support is now correctly recognized when either configuration explicitly enables or disables key management.

@c-r33d
c-r33d requested review from a team as code owners August 19, 2026 17:12
@coderabbitai

coderabbitai Bot commented Aug 19, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 88a4f92d-9878-4aca-bf63-773418003f15

📥 Commits

Reviewing files that changed from the base of the PR and between d1879ad and 584d997.

📒 Files selected for processing (1)
  • .github/workflows/xtest.yml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The workflow now checks both standard and preview KAS key-management settings. It enables support when either setting is explicitly true or false.

Changes

KAS key-management support

Layer / File(s) Summary
Key-management support detection
.github/workflows/xtest.yml
The workflow checks .services.kas.key_management and .services.kas.preview.key_management. Either explicit boolean value declares support.

Estimated code review effort: 2 (Simple) | ~5 minutes

Merge Risk: ⚪ Minimal · up to 584d9

This localized CI workflow change has no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: abarabash-virtru

Poem

A rabbit checks the KAS with care,
Two key paths now answer there.
True or false, the flags are bright,
Support is set when either’s right.
Hop, hop—cleaner checks tonight!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the CI change to support the stable key_management flag, which matches the main pull request objective.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch move-km-stable

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

Copy link
Copy Markdown

@c-r33d
c-r33d merged commit 6a7755f into main Aug 19, 2026
27 checks passed
@c-r33d
c-r33d deleted the move-km-stable branch August 19, 2026 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants