Unbounded attribute values in ListAttributes and GetAttribute responses #3744

Activity

1. eugenioenko

   added

   bugSomething isn't workingSomething isn't working

   on Jul 10, 2026
2. eugenioenko commented on Jul 10, 2026

   

   eugenioenko

   on Jul 10, 2026

   ContributorAuthor

   More actions

   Implementation Pattern

   Per direction to match existing proto patterns, the best template to follow is ListRegisteredResourceValues in the registered resources service — it's a clean paginated sub-resource listing with a parent ID filter.

   Proto Pattern

   From service/policy/registeredresources/registered_resources.proto (lines 284-299):

   message ListRegisteredResourceValuesRequest {
     string resource_id = 1;               // optional parent filter
     policy.PageRequest pagination = 10;
   }
   message ListRegisteredResourceValuesResponse {
     repeated policy.RegisteredResourceValue values = 1;
     policy.PageResponse pagination = 10;
   }

   SQL Pattern

   From service/policy/db/queries/registered_resources.sql (lines 242-289), uses a WITH counted CTE + LIMIT/OFFSET:

   WITH counted AS (
       SELECT COUNT(v.id) AS total
       FROM registered_resource_values v
       WHERE sqlc.narg('registered_resource_id')::uuid IS NULL 
          OR v.registered_resource_id = sqlc.narg('registered_resource_id')::uuid
   )
   SELECT
       v.id, ...,
       counted.total
   FROM registered_resource_values v
   JOIN registered_resources r ON v.registered_resource_id = r.id
   CROSS JOIN counted
   WHERE
       sqlc.narg('registered_resource_id')::uuid IS NULL 
       OR v.registered_resource_id = sqlc.narg('registered_resource_id')::uuid
   GROUP BY v.id, ..., counted.total
   ORDER BY v.created_at DESC
   LIMIT @limit_
   OFFSET @offset_;

   Go DB Layer Pattern

   From service/policy/db/registered_resources.go (lines 467-532):

   • getRequestedLimitOffset() to extract pagination params with defaults
   • Max limit enforcement via c.listCfg.limitMax
   • sqlc query execution
   • Hydrate proto objects from rows
   • getNextOffset() to compute next page offset
   • Return response with PageResponse

   Go Service Handler Pattern

   From service/policy/registeredresources/registered_resources.go (lines 281-292) — thin wrapper:

   func (s *Service) ListValues(ctx context.Context, req *connect.Request[...]) (*connect.Response[...], error) {
       rsp, err := s.dbClient.ListAttributeValues(ctx, req.Msg)
       if err != nil {
           return nil, db.StatusifyError(ctx, s.logger, err, db.ErrTextListRetrievalFailed)
       }
       return connect.NewResponse(rsp), nil
   }

   Notes

   • The previously removed ListAttributeValues already followed this exact pattern before it was deprecated in PR fix(policy): deprecate ListAttributeValues in favor of existing GetAttribute #3108. The fix is essentially re-introducing it with current conventions.
   • Shared pagination types (PageRequest/PageResponse) are defined in service/policy/selectors.proto.
   • Pagination helpers (getRequestedLimitOffset, getNextOffset) are in service/policy/db/utils.go.
3. eugenioenko commented on Jul 13, 2026

   

   eugenioenko

   on Jul 13, 2026

   ContributorAuthor

   More actions

   ADR with proposed fix
   #3747
4. eugenioenko commented on Aug 6, 2026

   

   eugenioenko

   on Aug 6, 2026

   ContributorAuthor

   More actions

   The current API doesn't return RANK either and attribute values cannot be sorted by rank. This might be a separate issue but V2 implementation needs to include RANK and ability to sort by rank. This way if there is 1M attribute values and you want to get the one from lowers rank instead of highest.