[BGP] nncp: add ipv4 gateway address to internalapi and storage bridges#783
Draft
eduolivares wants to merge 1 commit into
Draft
[BGP] nncp: add ipv4 gateway address to internalapi and storage bridges#783eduolivares wants to merge 1 commit into
eduolivares wants to merge 1 commit into
Conversation
Without an explicit ipv4 address in the NNCP desired state, NMState periodically reconciles the bridges and removes the gateway IP that the bridge CNI plugin sets via isGateway:true in the NAD. This causes the kernel connected route for the network to disappear, making pod IPs on those bridges unreachable from compute/networker nodes via BGP. The fix adds the gateway IP (first host IP of each subnet) to the NNCP so NMState preserves it across reconciliation cycles. Fixes: OSPRH-32725 Assisted-By: Claude Sonnet 4.6
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: eduolivares The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Contributor
|
/lgtm waiting for test results before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ipv4address in the NNCP desired state, NMState periodically reconciles theinternalapiandstoragebridges and removes the gateway IP that the bridge CNI plugin sets viaisGateway: truein the NAD.ovn-controllerto become unhealthy. The issue typically manifests after 24+ hours of operation.lib/nncp-l3(base template) and all BGP deployment examples that import it (bgp_dt01,bgp-l3-xl,dz-storage).Fixes: OSPRH-32725
Test plan
internalapiandstoragebridges retain their gateway IPs after NMState reconciliation🤖 Generated with Claude Code