Skip to content

Add OCP nodes peer_asn to BGP networking values (test eBGP)#754

Open
m-blue-m wants to merge 1 commit into
openstack-k8s-operators:mainfrom
m-blue-m:diff_asn_test_ebgp
Open

Add OCP nodes peer_asn to BGP networking values (test eBGP)#754
m-blue-m wants to merge 1 commit into
openstack-k8s-operators:mainfrom
m-blue-m:diff_asn_test_ebgp

Conversation

@m-blue-m

@m-blue-m m-blue-m commented May 7, 2026

Copy link
Copy Markdown
Contributor

Add peer_asn field to each worker node in network-values ConfigMap and wire kustomize replacements to set BGPPeer spec.peerASN per node.

This enables CI scenarios to override peerASN per OCP worker (for eBGP testing with different ASN values).

Notice no functional change, default value (64999) matches existing hardcoded peerASN.

Related: OSPRH-28085
Assisted-By: Claude

@openshift-ci openshift-ci Bot requested review from abays and leifmadsen May 7, 2026 14:53
@openshift-ci

openshift-ci Bot commented May 7, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: m-blue-m
Once this PR has been reviewed and has the lgtm label, please assign fultonj for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@m-blue-m m-blue-m self-assigned this May 7, 2026
@m-blue-m m-blue-m added the do-not-merge Changes are not ready to be merged label May 7, 2026
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/8d8a274e511346f7bbaf67e6f31f864a

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-bgp_dt01 FAILURE in 4m 35s

@m-blue-m m-blue-m force-pushed the diff_asn_test_ebgp branch from eb80596 to 0ccd6ee Compare May 19, 2026 15:27
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/2ffe2e768f3a40ae95f0991a5e7aaecc

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-bgp_dt01 FAILURE in 4m 07s

@m-blue-m m-blue-m force-pushed the diff_asn_test_ebgp branch from 0ccd6ee to 7e407d3 Compare June 7, 2026 15:46
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/0be9fa127c2749e78c88ebd0e9812e5a

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-bgp_dt01 FAILURE in 4m 06s

@m-blue-m m-blue-m force-pushed the diff_asn_test_ebgp branch from 7e407d3 to 6e580ac Compare June 10, 2026 11:26
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/964578c1c02c4120a68975e4cd34aa73

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-bgp_dt01 FAILURE in 4m 32s

@m-blue-m m-blue-m force-pushed the diff_asn_test_ebgp branch from 6e580ac to 2383686 Compare June 11, 2026 17:23
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/7606dfe81ead49d5b9b5b2b5073eff30

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-bgp_dt01 FAILURE in 4m 39s

@m-blue-m m-blue-m force-pushed the diff_asn_test_ebgp branch from 2383686 to 3702071 Compare July 7, 2026 15:24
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/533367b77213464bb40b3e0898c0cb16

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-bgp_dt01 FAILURE in 3m 41s

@m-blue-m m-blue-m force-pushed the diff_asn_test_ebgp branch from 3702071 to 16d5356 Compare July 9, 2026 08:51
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/5ab99f70ff0a4c8b96fe952ca6afca05

✔️ noop SUCCESS in 0s
rhoso-architecture-validate-bgp_dt01 FAILURE in 4m 44s

@m-blue-m m-blue-m force-pushed the diff_asn_test_ebgp branch from 16d5356 to b397577 Compare July 13, 2026 15:55
Add bgp_dt02 directory fully independent from bgp_dt01. Replaces
symlinks (control-plane, r0 computes/networkers, deployment) with
standalone copies to avoid inheriting dt01's native-ovn-bgp migration.
dt02 intentionally keeps ovn-bgp-agent; migration to native-ovn-bgp
is a separate follow-up task.

eBGP rack nodes (r1/r2 computes/networkers) set:
  edpm_frr_bgp_asn: 64899 (shared eBGP node ASN, separate from
    leaf ASN range 64999-64900 to avoid collision)
  edpm_ovn_bgp_agent_bgp_as: 64899 (must match FRR main router
    ASN, otherwise agent fails to configure VRF leak routes)
  edpm_frr_bgp_graceful_shutdown: false (RFC 8326, not applicable
    for eBGP nodes during normal operation)
  edpm_frr_bgp_uplinks_scope: external (eBGP peering with leaves)
  edpm_frr_bgp_neighbor_ttl_security_hops: 0 (disable GTSM for
    eBGP since leaves send default TTL)

OCP worker MetalLB peer_asn set per node to match each rack's
leaf ASN (64999/64998/64997).

Related: OSPRH-28085
Assisted-By: Claude Code
Signed-off-by: Maor Blaustein <mblue@redhat.com>
@m-blue-m m-blue-m force-pushed the diff_asn_test_ebgp branch from b397577 to ab1e1e0 Compare July 14, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Changes are not ready to be merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant