feat: Add OS-EP-FILTER provider CRUD to the catalog#1075
Open
mashawes wants to merge 2 commits into
Open
Conversation
Signed-off-by: Mohammed <mashawes@andrew.cmu.edu>
Signed-off-by: Mohammed <mashawes@andrew.cmu.edu>
mashawes
changed the title
gtema
requested changes
Jul 23, 2026
| project_id: &'a str, | ||
| endpoint_id: &'a str, | ||
| ) -> Result<(), CatalogProviderError> { | ||
| self.backend_driver |
Collaborator
There was a problem hiding this comment.
all modification operation must emit audit entry and notification event. Here is it done only for endpoint groups, but not modifying project<->endpoint bindings
| project_id: &'a str, | ||
| endpoint_id: &'a str, | ||
| ) -> Result<(), CatalogProviderError> { | ||
| self.backend_driver |
Collaborator
There was a problem hiding this comment.
also here audit and notifications are completely missing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the OS-EP-FILTER provider surface in the catalog provider, following the existing region/service/endpoint CRUD pattern against the pre-existing endpoint_group, project_endpoint, and project_endpoint_group tables.
All operations are threaded through the CatalogApi provider (provider_api, service, mock) and implemented in the catalog-sql driver. Endpoint group create, update, and delete emit audit events; the association operations are plain link-table mutations.
Test plan
Driver unit tests for every operation. Integration tests covering endpoint group CRUD (with validation and not-found cases) and full association lifecycles for both project/endpoint and project/endpoint-group. Run with cargo test and all pass.
Closes #914
Note: this contribution was developed with AI assistance.