Skip to content

[release-4.20] OCPBUGS-85155: Backport GatewayAPIWithoutOLM feature gate as disabled#2871

Open
gcs278 wants to merge 1 commit into
openshift:release-4.20from
gcs278:backport-4.20-GatewayAPIWithoutOLM-off
Open

[release-4.20] OCPBUGS-85155: Backport GatewayAPIWithoutOLM feature gate as disabled#2871
gcs278 wants to merge 1 commit into
openshift:release-4.20from
gcs278:backport-4.20-GatewayAPIWithoutOLM-off

Conversation

@gcs278
Copy link
Copy Markdown
Contributor

@gcs278 gcs278 commented Jun 3, 2026

Summary

Backport the GatewayAPIWithoutOLM feature gate definition to release-4.20 with all feature sets disabled. The gate is present but OFF — no behavioral change.

Why

  1. Unblocks test backports — test backports that reference the GatewayAPIWithoutOLM feature gate need the gate definition to exist so they can compile. Without it, any noOLM-dependent test backport to 4.20 will fail.

  2. Enables cleaner future backports — there is ongoing discussion about backporting the full noOLM / Sail Library path to 4.20 to address OLM subscription management issues (catalog source conflicts, detached subscriptions, disconnected cluster support). Having the gate already present makes that backport significantly cleaner if we decide to proceed.

Either way, this PR is safe — the gate is disabled in all feature sets and introduces no functional change.

Changes

  • Add FeatureGateGatewayAPIWithoutOLM to features/features.go with no enableIn call (disabled everywhere)

Mirror of #2864 (release-4.21)

Add the GatewayAPIWithoutOLM feature gate to release-4.20 with all
feature sets disabled. No behavioral change — the gate is present
but OFF. Unblocks cleaner backports of noOLM-dependent code and tests.

Cherry-picked from: a47ac12
openshift#2191

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. label Jun 3, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2026

Hello @gcs278! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@gcs278: This pull request references Jira Issue OCPBUGS-85149, which is invalid:

  • expected the bug to target either version "4.20." or "openshift-4.20.", but it targets "4.21.z" instead
  • expected dependent Jira Issue OCPBUGS-85148 to target a version in 4.21.0, 4.21.z, but it targets "4.22.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport the GatewayAPIWithoutOLM feature gate definition to release-4.20 with all feature sets disabled. The gate is present but OFF — no behavioral change.

Why

  1. Unblocks test backportsopenshift/origin#31139 needs the feature gate to exist so it can conditionally skip noOLM-dependent tests. Without the gate definition, the test backport can't compile.

  2. Enables cleaner future backports — there is ongoing discussion about backporting the full noOLM / Sail Library path to 4.20 to address OLM subscription management issues (catalog source conflicts, detached subscriptions, disconnected cluster support). Having the gate already present makes that backport significantly cleaner if we decide to proceed.

Either way, this PR is safe — the gate is disabled in all feature sets and introduces no functional change.

Changes

  • Add FeatureGateGatewayAPIWithoutOLM to features/features.go with no enableIn call (disabled everywhere)

Mirror of #2864 (release-4.21)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 3, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Jun 3, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository: openshift/coderabbit/.coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 115fcef0-7963-41c8-aea8-bf7c4ef733b6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 3, 2026
@gcs278 gcs278 marked this pull request as ready for review June 3, 2026 00:42
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 3, 2026
@openshift-ci openshift-ci Bot requested review from JoelSpeed and everettraven June 3, 2026 00:42
@gcs278 gcs278 changed the title [release-4.20] OCPBUGS-85149: Backport GatewayAPIWithoutOLM feature gate as disabled [release-4.20] OCPBUGS-XXXXX: Backport GatewayAPIWithoutOLM feature gate as disabled Jun 3, 2026
@openshift-ci-robot openshift-ci-robot removed jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Jun 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@gcs278: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

Details

In response to this:

Summary

Backport the GatewayAPIWithoutOLM feature gate definition to release-4.20 with all feature sets disabled. The gate is present but OFF — no behavioral change.

Why

  1. Unblocks test backports — test backports that reference the GatewayAPIWithoutOLM feature gate need the gate definition to exist so they can compile. Without it, any noOLM-dependent test backport to 4.20 will fail.

  2. Enables cleaner future backports — there is ongoing discussion about backporting the full noOLM / Sail Library path to 4.20 to address OLM subscription management issues (catalog source conflicts, detached subscriptions, disconnected cluster support). Having the gate already present makes that backport significantly cleaner if we decide to proceed.

Either way, this PR is safe — the gate is disabled in all feature sets and introduces no functional change.

Changes

  • Add FeatureGateGatewayAPIWithoutOLM to features/features.go with no enableIn call (disabled everywhere)

Mirror of #2864 (release-4.21)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@gcs278
Copy link
Copy Markdown
Contributor Author

gcs278 commented Jun 3, 2026

I need to wait for an OCPBUGS (probably a backport of https://redhat.atlassian.net/browse/OCPBUGS-85149) or use NOJIRA for this - but still could be tagged otherwise.

@JoelSpeed
Copy link
Copy Markdown
Contributor

/lgtm
/label backport-risk-assessed

@gcs278 valid bug and verified are for you to work out

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Jun 3, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 3, 2026
@openshift-merge-bot
Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-aws-ovn
/test e2e-aws-ovn-hypershift
/test e2e-aws-ovn-hypershift-conformance
/test e2e-aws-ovn-techpreview
/test e2e-aws-serial-1of2
/test e2e-aws-serial-2of2
/test e2e-aws-serial-techpreview-1of2
/test e2e-aws-serial-techpreview-2of2
/test e2e-azure
/test e2e-gcp
/test e2e-upgrade
/test e2e-upgrade-out-of-change

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 3, 2026
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 3, 2026

@gcs278: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn 30108b3 link true /test e2e-aws-ovn
ci/prow/e2e-gcp 30108b3 link false /test e2e-gcp

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gcs278 gcs278 changed the title [release-4.20] OCPBUGS-XXXXX: Backport GatewayAPIWithoutOLM feature gate as disabled [release-4.20] OCPBUGS-85155: Backport GatewayAPIWithoutOLM feature gate as disabled Jun 3, 2026
@openshift-ci-robot openshift-ci-robot added jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Jun 3, 2026
@gcs278
Copy link
Copy Markdown
Contributor Author

gcs278 commented Jun 3, 2026

/refresh jira

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Jun 3, 2026
@openshift-ci-robot
Copy link
Copy Markdown

@gcs278: This pull request references Jira Issue OCPBUGS-85155, which is invalid:

  • expected dependent Jira Issue OCPBUGS-85149 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is POST instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Summary

Backport the GatewayAPIWithoutOLM feature gate definition to release-4.20 with all feature sets disabled. The gate is present but OFF — no behavioral change.

Why

  1. Unblocks test backports — test backports that reference the GatewayAPIWithoutOLM feature gate need the gate definition to exist so they can compile. Without it, any noOLM-dependent test backport to 4.20 will fail.

  2. Enables cleaner future backports — there is ongoing discussion about backporting the full noOLM / Sail Library path to 4.20 to address OLM subscription management issues (catalog source conflicts, detached subscriptions, disconnected cluster support). Having the gate already present makes that backport significantly cleaner if we decide to proceed.

Either way, this PR is safe — the gate is disabled in all feature sets and introduces no functional change.

Changes

  • Add FeatureGateGatewayAPIWithoutOLM to features/features.go with no enableIn call (disabled everywhere)

Mirror of #2864 (release-4.21)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. jira/severity-low Referenced Jira bug's severity is low for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants