Drop AZURE_OPENAI_DEPLOYMENT in favour of OPENSCIENTIST_MODEL - #295
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Azure's OpenAI v1 surface takes the deployment name as the model in the request body, which is how this provider has always routed, so
AZURE_OPENAI_DEPLOYMENTwas a second spelling of the model name. It is gone.OPENSCIENTIST_MODELnow carries the deployment name and is required whenever the provider isazure-openai. The provider enforces no naming pattern on its model, so whatever name an operator gave their deployment still validates.Three comments were contradicting the code and are corrected along the way. The module docstring claimed Azure selects the model from the URL path rather than the request body, which the base URL builder already disproved, and the job model resolver cited the Azure deployment as its example of a provider that carries its own model.
An operator with the old variable still set in an environment or
.envfile has to move its value toOPENSCIENTIST_MODEL. The old name is now simply ignored, so the symptom of forgetting is a startup complaint thatOPENSCIENTIST_MODELis required.