Repository navigation
dawn: retry dependency downloads and propagate Git failures - #642
Merged
danoli3 merged 1 commit intoOct 15, 2026
Merged
Conversation
Avoid silently accepting failed dependency fetches and empty checkouts. Retry network Git operations three times, use original GitHub endpoints for Chromium GitHub mirrors, and preserve every pinned DEPS commit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several otherwise successful platform jobs fail while downloading Dawn dependencies: Google-hosted mirrors return HTTP 502/503, and the pinned downloader ignores Git failures. Windows then reaches CMake with an empty SPIRV-Tools directory and reports a missing CMakeLists.txt.
Patch the pinned downloader to retry fetch/clone operations up to three times and propagate exhausted failures. Preserve expected unsuccessful Git probes when recovering partial repositories. Use the original GitHub endpoints for dependencies mirrored from GitHub, retaining their exact DEPS commits. Retry Dawn and depot_tools network fetches too, and increment BUILD_ID to invalidate old outputs.
Validation: patch applies to the pinned upstream script; Python compilation, transient/permanent failure and checkout-error fixtures, Bash syntax, checksum audit and whitespace checks pass. Native platform builds remain pending.