Repository navigation
opencv5: include iterator for stereo back inserters - #626
Merged
danoli3 merged 3 commits intoOct 11, 2026
Merged
Conversation
Fix MSYS2 Clang builds with newer libc++ that no longer provide std::ostream through transitive includes. Apply the header fix idempotently and invalidate cached Assimp outputs.
Fix MSYS2 Clang ARM64 compilation with newer libc++ by including the standard header that declares std::back_inserter. Apply the patch idempotently and invalidate cached OpenCV 5 outputs.
danoli3
force-pushed
the
fix-opencv5-stereo-iterator
branch
from
October 11, 2026 05:48
6fad1cd to
17398ce
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MSYS2 Clang ARM64 compilation fails in OpenCV 5.0.0
modules/stereo/src/stereo_geom.cppbecausestd::back_inserteris unavailable. The source uses it without including<iterator>, relying on transitive precompiled-header includes that newer libc++ no longer supplies.Add the required include with an idempotent prepare patch and increment OpenCV 5's build ID. Keep stereo enabled and preserve the source pin and existing platform patches.
This is the next independent error exposed in #625: Assimp itself successfully completed in that job.
Validation: patch applies cleanly to the tagged 5.0.0 source and reverse dry-run succeeds; Bash syntax, diff checks and formula checksum audit (44/44) passed. Full OpenCV target compilation awaits native CI.
Failure: https://github.com/openframeworks/apothecary/actions/runs/38104733694/job/114386399882
Stack update: #625 is rebased onto current bleeding; #626 is rebased on top of #625 and contains both fixes. Both PRs target bleeding because the prerequisite branch lives in the contributor fork. Use #626 CI to validate the combined fixes; #625 alone can still encounter the independently fixed OpenCV iterator error. Merge order: #625, then #626. After #625 merges, rebase #626 onto bleeding so its diff contains only the OpenCV fix.