Add all-band selection actions - #401
Merged
Merged
Conversation
Contributor
|
Thanks @eriklindquist for this PR. Could you please split the two features into two independent commits? They can remain on the same branch, but splitting them would make the review easier. For the commit messages/descriptions, please only include information that isn’t evident from the code itself. Some of the information in the current commit description can be moved or merged into the PR.body. |
eriklindquist
force-pushed
the
classification-select-all-bands
branch
from
August 24, 2026 09:21
320bc97 to
6d81d6d
Compare
Placed as an entry inside the existing add-band dropdown (rather than a separate button, which was the first iteration) so it uses the same single point of interaction as adding individual bands.
dfguerrerom
force-pushed
the
classification-select-all-bands
branch
from
August 24, 2026 12:38
6d81d6d to
3d8e929
Compare
dfguerrerom
changed the title
dfguerrerom
changed the title
dfguerrerom
force-pushed
the
classification-select-all-bands
branch
5 times, most recently
from
August 25, 2026 13:01
5e3743a to
46a60ef
Compare
dfguerrerom
force-pushed
the
classification-select-all-bands
branch
from
August 25, 2026 13:10
46a60ef to
d9d83d3
Compare
dfguerrerom
reviewed
Aug 25, 2026
| shape='circle' | ||
| title={removeTitle} | ||
| message={removeMessage} | ||
| confirmationLabel={removeConfirmationLabel} |
Contributor
There was a problem hiding this comment.
@lpaolini we did have to add the confirmation label param
Contributor
|
Updated after testing the band-selection flows more broadly.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Band selectors in Classification, Regression, Unsupervised Classification, Remapping, Stack, and Band Math now use consistent Image bands collections with inline add and remove-all actions. Bulk selection is collision-safe for real bands named all, add controls disable when complete, and empty collections stay visible. Verified inside the running GUI container with full ESLint and Vitest: 85 files and 1,176 tests passed. The sampling-control work remains split into #408.