fix(grok): map Always allow to allow_once when Grok omits allow_always - #228
Merged
Merged
Conversation
…anges Grok health checks opened a full ACP session, so background probes could hang on authenticate or boot every configured MCP server. They also never reported login state, and the snapshot locked model changes to a new thread even though session/set_model already works. The check now runs grok --version, grok models, then a single ACP initialize and reads models from _meta.modelState. Failed initialize degrades to warning. grok-build is never sent as a model id. Adapted from pingdotgg#9154 and pingdotgg#8392. Made by Grok 4.6 High in Grok Build via Orca.
Keep the Grok probe PR current with main.
… steers Grok CLI dropped session/cancel because effect-acp encoded notifications as requests with an empty id and headers. Stop then queued the next prompt behind work that never cancelled. Notifications now encode as JSON-RPC with no id. Cancel waits for that write. A mid-turn send cancels the in-flight prompt and continues the same turn. Adapted from pingdotgg#9154. Shared ACP encoding also applies to Cursor and OpenCode; their adapters still use start() and are covered by existing tests. Made by Grok 4.6 High in Grok Build via Orca.
Grok 4.6 often omits ACP allow_always. Choosing Always allow this session then mapped to a missing option and cancelled the turn. Fall back to allow_once so the command still runs. Session-scoped auto-approval memory from the same upstream work is not in this change. Adapted from pingdotgg#8358. Made by Grok 4.6 High in Grok Build via Orca.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
Bot
added
type:provider
Greptile SummaryThis PR improves Grok permission handling when Confidence Score: 5/5Safe to merge. There are no outstanding findings. The previously reported test fixture type-widening issue is fully fixed: the request now uses Reviews (4): Last reviewed commit: "merge main into grok approvals stack" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
CI typecheck inferred permission option kinds as string, so the new allow_once fallback test failed to compile. Annotate the fixture with satisfies RequestPermissionRequest so the ACP literal union is preserved. Made by Grok 4.6 High in Grok Build via Orca.
A successful replacement could be reported as cancelled when the superseded prompt finished local draining last. The last in-flight settlement owned the terminal state. Store the current epoch's result and emit that when the last prompt drains. Unit tests cover both settlement orders. Made by Grok 4.6 High in Grok Build via Orca.
Keep the Grok permission fallback stacked on the steered-turn epoch settlement fix.
4 of 5 tasks
leoisadev1
changed the base branch from
leoisadev1/t3-port-grok-cancel
to
main
September 13, 2026 22:05
This was referenced Sep 13, 2026
Merged
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Grok 4.6 often omits ACP
allow_always. Choosing Always allow this session then mapped to a missing option and cancelled the turn.Changes
selectGrokPermissionOptionIdfalls back toallow_oncewhenallow_alwaysis absent. The command still runs.Session-scoped auto-approval memory from the same upstream work is not in this change.
Upstream
Adapted from pingdotgg/t3code#8358. Stacked on #224.
Verification
Leave this PR and its base open.
Made by Grok 4.6 High in Grok Build via Orca.