docs: supersede Hub Gateway Tools UI with package-owned Control UI - #1460
MythiliMur wants to merge 3 commits into
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs real behavior proof before merge. Reviewed September 21, 2026, 10:00 PM ET / September 22, 2026, 02:00 UTC (Revision 3). ClawSweeper reviewWhat this changesAdds a Windows Hub page, package activation and local broker client for registering desktop executables with the isolated Gateway, plus a design proposal and presentation tests. Merge readiness⛔ Blocked before merge - 22 items remain Keep open: current main does not provide this capability. All seven previous findings remain, and the activation commit introduces three additional defects. The companion broker has progressed, but runtime readiness and the cross-identity security boundary remain unproven. Priority: P2 Review scores
Verification
How this fits togetherGateway Tools connects desktop users to a package-owned broker that makes selected executables available to the isolated Gateway. The Hub requests operations and displays status; packaging owns registrations, runtime profiles and executable shims. flowchart LR
A[Desktop user] --> B[Gateway Tools page]
B --> C[Package activation]
B --> D[Local pipe client]
C --> E[Packaging broker]
D --> E
E --> F[Registration and runtime permissions]
F --> G[Isolated Gateway execution]
E --> B
Decision needed
Why: No recorded maintainer decision sponsors the new cross-identity capability, and the companion implementation remains unmerged and incomplete. Before merge
Findings
Agent review detailsSecurityNeeds attention: Registration consent, broker identity and persisted execution authority remain unresolved security boundaries. Review metrics
Merge-risk optionsMaintainer options:
Technical reviewBest possible solution: Keep the Hub a thin client behind an approved packaging contract, with explicit consent, verified broker identity, effective revocation and clear unavailable states. Do we have a high-confidence way to reproduce the issue? Yes for the introduced defects: source and Windows API contracts establish build failures, invalid activation, missing navigation loading and unbounded waits. No Windows build or runtime reproduction was executed. Is this the best way to solve the issue? Unclear as a product direction. The thin-client ownership split is appropriate, but this implementation needs an approved broker contract and substantial correctness repairs before exposure. Full review comments:
Overall correctness: patch is incorrect AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 3e740827aeb1. LabelsLabel justifications:
EvidenceSecurity concerns:
What I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
HistoryReview history (2 earlier review cycles)
|
|
ClawSweeper status: review started. I am starting a fresh review of this pull request: docs: supersede Hub Gateway Tools UI with package-owned Control UI This is item 1/1 in the current shard. Shard 0/1. This temporary status tracks the active review worker. The completed review will appear in the durable ClawSweeper review comment. Crustacean status: shell secured, claws on keyboard, evidence pebbles being sorted. |
|
Closing because Gateway Tools management now lands in the package-owned Gateway Control UI. The authoritative Runtime Bridge is tracked in openclaw/openclaw-windows-packaging#92; the dependent package UI follow-up is openclaw/openclaw-windows-packaging#94. This Hub draft remains reference material for earlier bounded client/UI concepts, but it is no longer the implementation target. |
Status: superseded implementation direction
This draft documents and contains the earlier Windows Hub client/UI slice for the package-side Gateway Tool Runtime Bridge.
The product direction has since moved the Gateway Tools management surface into the package-owned Gateway Control UI. Future UI work belongs in
openclaw/openclaw-windows-packaging#92, alongside the authoritative broker, managed-profile lifecycle, and package-owned Control UI Adapter.This PR remains a reference for the earlier bounded client DTOs and UI behavior, but it is not the landing target for the current feature.
Retained security intent
The earlier Hub client deliberately had no authority over:
Those boundaries remain required. The package-owned implementation will retain this bounded-status model while keeping privileged actions behind the packaging broker.
Validation
git diff --check