chore: adopt plugin-inspector 0.3.25 - #303
Conversation
|
🦞👀 Pull request received. I will update this pull request when review starts. ClawSweeper review completeClawSweeper finished reviewing this revision. The review result is being finalized. |
|
Codex review: needs maintainer review before merge. Reviewed September 9, 2026, 1:10 PM ET / 17:10 UTC. ClawSweeper reviewWhat this changesUpdates Crabpot’s inspector source and npm package pins to 0.3.25, along with matching test guards and operational documentation. Merge readiness✅ Ready for maintainer review The adoption remains necessary: neither current main nor the latest Crabpot release includes it. The focused patch and recorded compatibility checks support landing through the normal maintainer process; no blocking defect was found. Priority: P2 Review scores
Verification
How this fits togetherCrabpot uses plugin-inspector to examine configured plugin fixtures and produce compatibility reports. Its loader selects source or published-package execution, while Crabpot retains fixture selection and reporting orchestration. flowchart TD
A[Configured plugin fixtures] --> B[Crabpot inspection commands]
B --> C{Inspector selection}
C --> D[Pinned source or development override]
C --> E[Published npm package]
D --> F[Inspect plugin contracts]
E --> F
F --> G[Compatibility reports and check status]
Before mergeNone. Agent review detailsSecurityNone. Review metrics
Technical reviewBest possible solution: Keep source and published inspector versions aligned while preserving fixture pins, report contracts, and explicit development overrides. Do we have a high-confidence way to reproduce the issue? Not applicable: this is a dependency adoption, and current main’s older pins are directly observable in source. Is this the best way to solve the issue? Yes: updating the existing loader constants and matching guards follows the established integration path, with recorded source/package parity checks supporting unchanged report expectations. AGENTS.md: found and applied where relevant. Codex review notes: model internal, reasoning medium; reviewed against 6219f185358f. LabelsLabel changes:
Label justifications:
EvidenceWhat I checked:
Likely related people:
Rating scale
Overall follows the weaker of proof and patch quality. Workflow
|
What Problem This Solves
Crabpot's default packaged inspector remained on 0.3.24, while its source pin lacked the completed 0.3.25 lifecycle, timeout, CommonJS capture, and Gateway validation repairs.
Why This Change Was Made
Pins both source and published-package modes to the verified 0.3.25 release, updates their existing test guards, and brings the two operational docs and changelog into agreement. No fixture, host, runtime logic, workflow, or report expectation changes.
Related release: openclaw/plugin-inspector#75
User Impact
Default package-mode smoke and pinned source consumers now use the released inspector repairs. Development overrides remain available; the docs explain how to keep source-mode and fresh-cache published-mode checks distinct.
Evidence
39d79acfe352aee270fb6186e1604d84a705e32f, based on Crabpot main6219f185358ff03219bf2953c6b114ffaee9a78a. Five files, 19 additions and 16 deletions.2e21b3b48aa06fea30b08202f4c6be13c1f3216a, annotated release https://github.com/openclaw/plugin-inspector/releases/tag/v0.3.25. Existing tag-push trusted-publishing workflow passed at that exact SHA: https://github.com/openclaw/plugin-inspector/actions/runs/34380426028.gitHead, latest tag, integrity, signatures, and provenance verified. The provenance subject binds the package digest to the exact source SHA, release tag, workflow, and run. Fresh registry installation with scripts disabled passed all 19 public exports, root API and CLI checks, and byte comparison of all 59 package files against the release commit.d29d54c51d729f2162473a242e1a0d00e0c5ba75eb5b2b67b2aa2aed40dc6151, identical to the reviewed candidate.npm run plugin-inspector:smokein default published mode passed all 59 unchanged fixtures with zero breakages.CRABPOT_PLUGIN_INSPECTOR_BIN,CRABPOT_PLUGIN_INSPECTOR_CLI, andCRABPOT_PLUGIN_INSPECTOR_DIRwere unset; npm used a fresh cache and disabled lifecycle scripts.5570c5ffac86acb74979c7314da6f3364781985aalso matches source/packed reports: 59 fixtures, zero fixture breakages, 384 findings including nine live/P0 findings. One published 0.3.24 baseline on those exact inputs confirms all 384 issues are unchanged. The host's re-exported compat registry remains a pre-existing parser limitation, not hidden by an expectation change.release:crabpot --expected-ref 2e21b3b48aa06fea30b08202f4c6be13c1f3216a --expected-version 0.3.25 --publishedpassed. This checklist does not execute smokes; the actual runs are recorded separately above.git diff --checkpassed.39d79acfe352aee270fb6186e1604d84a705e32f: Linux, macOS, Windows, container, fixture-security scope check, and requiredDefault Track (pinned OpenClaw)aggregate are green: https://github.com/openclaw/crabpot/actions/runs/34380916198. CodeQL passed at the same head: https://github.com/openclaw/crabpot/actions/runs/34380914227.Fixture Impact
Dependency source/package pins, matching test guards, and release documentation only. All fixture versions, configuration, and expectations remain unchanged.
Fixture Verification
npm testnode scripts/sync-fixtures.mjs --checknode scripts/run-contract-smoke.mjsThe full materializing suite was not rerun locally for this pin/docs delta. Actual inspector source/packed/published inventory and pinned-host report checks and focused consumer tests are listed above. Native exact-head PR CI subsequently passed on all four required static lanes.
Notes
No external runtime services or credentials were used. Static report success is not a claim that the pinned host is free of compatibility findings or that external plugins executed successfully. Existing maintainer drafts and unrelated fixture-containment work are untouched. The source owner accepted the final five-file diff, publication binding, actual smokes, P2 review, and exact-head required CI, and granted the serial merge slot for this head. The separate advisory HEAD canary is not a required gate; its Windows report finalization was still running when merge clearance was granted.