fix: avoid kill timeout exit delays#601
Merged
gustavohenke merged 1 commit intoJul 21, 2026
Merged
Conversation
gustavohenke
self-requested a review
July 21, 2026 05:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
When
killTimeoutis enabled,KillOthersschedules a referenced timer before sending the initial termination signal. If all targeted processes stop cooperatively, that timer is the only remaining active handle and keepsconcurrentlyrunning until the full timeout expires.Fix
Unreference the force-kill timer. A child process that is still running continues to keep Node alive, so the timer can still deliver
SIGKILL; once every child has stopped, the timer no longer delays exit.Testing
pnpm exec vitest run --project unit lib/flow-control/kill-others.spec.tspnpm testpnpm exec vitest --coveragepnpm typecheckpnpm lintpnpm exec prettier --check "**/*.{json,y?(a)ml,md}"pnpm buildpnpm test:smoke