deps: upgrade shell-quote to 1.9.0#599
Merged
Merged
Conversation
Bumps shell-quote from 1.8.4 to 1.9.0. Used by
lib/command-parser/expand-arguments.ts for quoting additional arguments
when expanding {1}, {@}, and {*} placeholders.
Verified with pnpm typecheck, pnpm test (630 tests), pnpm test:smoke
(4 tests), and a manual CLI run exercising placeholder expansion.
|
coverage: 98.858%. remained the same — Mayvis:deps/shell-quote-1.9.0 into open-cli-tools:main |
Collaborator
|
As correctly mentioned above, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
shell-quotefrom1.8.4to1.9.0. The only consumer in thiscodebase is lib/command-parser/expand-arguments.ts,
which uses
quote()to escape the additional arguments substitutedinto
{1}/{@}/{*}placeholders.Refs #597
Security
Pulls in fix for GHSA-395f-4hp3-45gv
/ CVE-2026-13311 — quadratic-time DoS in
parse()(High, CVSS 7.5),affected versions ≤ 1.8.4.
Note:
concurrentlyonly consumesquote(), so this codebase is notdirectly exposed to the
parse()DoS. The upgrade also picks up abehavior change in
quote()that escapes a leading~to preventunintended shell tilde-expansion, which is relevant to the
{1}/{@}/{*}placeholder pipeline.Verification
pnpm typecheck— passespnpm test— 630 unit tests passing across 28 filespnpm test:smoke— 4 smoke tests passingpnpm build— succeeds./dist/bin/index.js -P 'echo arg is {1} all are {@}' -- foo bar→
arg is foo all are foo barTest plan