Skip to content

MorphoERC4626SwapConnectors: restore deployed rounding fix on main #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Kay-Zee wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

MorphoERC4626SwapConnectors: restore deployed rounding fix on main #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion cadence/contracts/connectors/evm/morpho/MorphoERC4626SwapConnectors.cdc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,10 +178,19 @@ access(all) contract MorphoERC4626SwapConnectors {
}

access(self) fun quoteRequiredSharesForAssets(desiredAssets: UFix64): {DeFiActions.Quote} {
let desiredAssetsEVM = FlowEVMBridgeUtils.convertCadenceAmountToERC20Amount(
let assetDecimals = FlowEVMBridgeUtils.getTokenDecimals(evmContractAddress: self.assetEVMAddress)
let desiredAssetsEVMFloor = FlowEVMBridgeUtils.convertCadenceAmountToERC20Amount(
desiredAssets,
erc20Address: self.assetEVMAddress
)
// Round up if the asset's EVM decimal precision is less than Cadence's 8 decimals.
// Truncation would cause the returned shares to produce less than desiredAssets when
// redeemed (since redeem is floor-rounding). Ceiling the EVM amount ensures the shares
// from previewWithdraw(ceil) will produce >= desiredAssets on redemption.
let desiredAssetsFloorBack = EVMAmountUtils.toCadenceOut(desiredAssetsEVMFloor, decimals: assetDecimals)
let desiredAssetsEVM = desiredAssetsFloorBack < desiredAssets
? desiredAssetsEVMFloor + 1
: desiredAssetsEVMFloor

if let requiredSharesEVM = ERC4626Utils.previewWithdraw(vault: self.vaultEVMAddress, assets: desiredAssetsEVM) {
if !self.canServiceRedemption(assetsEVM: desiredAssetsEVM) {
Expand Down
Loading