Skip to content

Issue #185: fix archived session deletion - #214

Closed
NWYLZW wants to merge 1 commit into
mainfrom
codex/issue-185-delete-archived-session
Closed

NWYLZW wants to merge 1 commit into
mainfrom
codex/issue-185-delete-archived-session

Conversation

@NWYLZW

@NWYLZW NWYLZW commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Root cause and user impact

The archived-session row's single-delete trigger stopped the click event on the button itself, so Ant Design's Popconfirm/rc-trigger path did not reliably open. Users received no confirmation, deletion, or error feedback when deleting one archived session, even though batch deletion still worked.

What changed

  • Make the single-session confirmation controlled so exactly one row can own the open confirmation at a time.
  • Keep the row actions visible while focused or confirming.
  • Route single and batch deletion through one guarded helper.
  • Deduplicate IDs and block duplicate requests while a deletion is pending.
  • Keep failed single deletes open and retryable with clear error feedback.
  • Remove only successfully deleted IDs from the SWR cache, then revalidate.
  • Preserve batch behavior, including retaining failed selections for retry after a partial failure.

Validation

  • Vitest regression suite: 4/4 passed
    • opens one labeled confirmation and cancel preserves the row
    • confirms exactly one delete, guards duplicate pending clicks, and updates the mounted UI
    • keeps a failed delete open and retryable
    • preserves batch deletion for selected archived sessions
  • Web-test TypeScript check: PASS
  • ESLint: PASS
  • dprint: PASS
  • Diff verification: PASS — exactly 1 commit and 3 changed files over main
  • Independent code review: PASS
  • Real Browser / rc-trigger visual runtime verification: pending

Closes #185

@vercel

vercel Bot commented Jul 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
oneworks-dev Ready Ready Preview Jul 30, 2026 7:04am

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Experience Review

Before merge, make sure the PR body contains this completed checklist:

## Experience Review
- [x] 已判断是否需要沉淀经验
- [x] 如需要,已运行 `$post-task-experience-review`
- [x] reviewer PASS 后才进入 merge

Checklist to confirm:

  • Decide whether this PR produced reusable project experience.
  • If experience should be captured, run $post-task-experience-review.
  • Merge only after the independent reviewer reports PASS.

@NWYLZW

NWYLZW commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by merged PR #320, which completed Issue #185 on current main with the reviewed exact scope. Closing this older unmerged PR for audit clarity; its branch is otherwise preserved.

@NWYLZW

NWYLZW commented Aug 9, 2026

Copy link
Copy Markdown
Contributor Author

Closed after successor PR #320 merged.

@NWYLZW NWYLZW closed this Aug 9, 2026

This branch was successfully deployed

1 active deployment
Preview — 3dc80455 Deployed Jul 30, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[UX][P1] 已归档会话的单条删除按钮无响应

1 participant