Say in plugins.md which services survive a plugin hot-reload - #10580
Open
steelcityappliance wants to merge 1 commit into
Open
Say in plugins.md which services survive a plugin hot-reload#10580steelcityappliance wants to merge 1 commit into
steelcityappliance wants to merge 1 commit into
Conversation
plugins.md tells an agent that saving a file under ~/.config/omarchy/plugins/ reloads plugin code automatically, with rescanPlugins as the fallback. For a service whose manifest sets keepLoaded that is not true: since omacom#9485, unloadPluginServices() keeps such a service mounted across a hot-reload so the lock client is not destroyed while Hyprland still holds the session lock. The running instance, its readonly constants included, stays live until `omarchy restart shell`. omarchy.lock, omarchy.notifications and omarchy.polkit declare the flag, and `omarchy plugin clone` copies the manifest, so a cloned notifications service behaves the same way. An agent following the current text edits the clone, rescans, sees the plugin listed as enabled, and gets the old behavior with nothing to say why. Name the exception where the claim is made. The reload path itself is left as is; omacom#10087 reports that hot-reload of widget code fails too, and that is a shell change, not a doc one. Fixes omacom#9999 Written by Claude Fable 5.1 via Claude Code, reviewed by Marc Morriss Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
plugins.mdtells an agent that saving a file under~/.config/omarchy/plugins/reloads plugin code automatically, withrescanPluginsas the fallback. For a service whose manifest setskeepLoadedthat is not true: since #9485,unloadPluginServices()keeps such a service mounted across a hot-reload so the lock client is not destroyed while Hyprland still holds the session lock. The running instance, itsreadonly propertyconstants included, stays live untilomarchy restart shell.omarchy.lock,omarchy.notificationsandomarchy.polkitdeclare the flag, andomarchy plugin clonecopies the manifest, so a cloned notifications service behaves the same way. An agent following the current text edits the clone, rescans, sees the plugin listed as enabled, and gets the old behavior with nothing to say why.Change
One paragraph in
default/agents/skills/omarchy/plugins.md: name the exception where the claim is made, list the three first-party services that carry it plus their clones, and say thatomarchy restart shellis the way to pick up edits to them. The rest of the paragraph is unchanged.Scoped to the skill the issue names.
docs/omarchy-shell.md:40already states thatkeepLoadedkeeps a service mounted across hot-reload, so the reference tree is right;manual/32-shell-plugins.md:71andshell/README.md:165carry the same unqualified sentence as the skill did and could take the same clause in a follow-up. The reload path itself is left as is: #10087 reports that hot-reload of widget code fails too, and that is a shell change, not a doc one; this PR does not claim to address it.Tests
Doc-only change; no executable touched.
test/shell.d/plugins-test.shstill asserts that the three services staykeepLoadedand thatunloadPluginServiceshonors the flag, which is the behavior the new sentence describes.Fixes #9999
Related: #9485 (the mechanism), #10087 (the separate hot-reload bug, not addressed here).
Written by Claude Fable 5.1 via Claude Code, reviewed by Marc Morriss