Conversation
Verify that requests outliving the plugin remain in cached dependency facts. Use two jobs so the regression runs independently of job-slot lending. The caught required-dependency regression is already upstream in ocaml#16407. Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cover unsandboxed dependency requests that outlive the action-plugin process. The producer waits for the plugin to exit; subsequent changes to its input must rerun the plugin, verifying that late dependency facts are retained in the rule cache.
Use two jobs so this regression runs on main independently of the separate job-slot lending change.