Skip to content

test(action-plugin): expose missing package dependency inference #16356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgrinberg wants to merge 1 commit into
base: main
Choose a base branch
from
Open

test(action-plugin): expose missing package dependency inference #16356

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
67 changes: 67 additions & 0 deletions otherlibs/dune-rpc-lwt/test/action-plugin/one-dependency/packages.t
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
Package dependency inference currently ignores dynamically discovered inputs,
including when it inspects a rule restored from the workspace cache.

$ cat > dune-project <<'EOF'
> (lang dune 2.3)
> (using action-plugin 0.1)
> (name sample)
> (strict_package_deps)
> (package (name consumer))
> (package (name provider))
> EOF
$ cp bin/foo.exe .
$ printf input > input
$ cat > dune <<'EOF'
> (install (package provider) (section share) (files input))
> (install (package consumer) (section share) (files output))
> (rule
> (target output)
> (action
> (with-stdout-to output
> (dynamic-run ./foo.exe read ../install/default/share/provider/input))))
> EOF
$ dune build consumer.install > fresh.output 2>&1; echo $?
0
$ dune build @install > cached.output 2>&1; echo $?
0

Without strict package checks, the package-files alias should still include the
inferred dependency's other installed files.

$ mkdir ordinary
$ cp bin/foo.exe ordinary/
$ cd ordinary
$ cat > dune-project <<'EOF'
> (lang dune 3.24)
> (using action-plugin 0.1)
> (name sample)
> (package (name consumer))
> (package (name provider))
> EOF
$ printf input > input
$ printf extra > extra
$ cat > dune <<'EOF'
> (install (package provider) (section share) (files input extra))
> (install (package consumer) (section share) (files output))
> (rule
> (target output)
> (action
> (with-stdout-to output
> (dynamic-run ./foo.exe read ../install/default/share/provider/input))))

@Alizter Alizter Sep 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't work even for regular run because we no longer use the install staging area for package deps.

@Alizter Alizter Sep 8, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also don't expand a package files alias any longer, so this test is a bit stale.

> EOF
$ dune build @.consumer-files > dynamic.output 2>&1
$ test -f _build/install/default/share/provider/input
$ test -f _build/install/default/share/provider/extra
[1]

A static read of the same installed file does infer the package dependency.

$ cat > dune <<'EOF'
> (install (package provider) (section share) (files input extra))
> (install (package consumer) (section share) (files output))
> (rule
> (target output)
> (action (copy %{pkg:provider:share:input} output)))
> EOF
$ dune build @.consumer-files --build-dir _build-static
$ test -f _build-static/install/default/share/provider/extra
Loading