Skip to content

test(opam_solver): solving sudokus - #16325

Open
art-w wants to merge 1 commit into
ocaml:mainfrom
art-w:opam-sudoku-solver
Open

art-w wants to merge 1 commit into
ocaml:mainfrom
art-w:opam-sudoku-solver

Conversation

@art-w

@art-w art-w commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Signed-off-by: Arthur Wendling <arthur@tarides.com>

@Alizter Alizter left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this is a cute example, I don't think we can afford having a monolithic test that takes 3s to run, especially if it isn't testing something directly. This test is doing some broad coverage and also acting as a benchmark. I think we should split this.

I would recommend:

  1. Extending conflict-class.t to have a longer conflict class list perhaps with another package that shares an entry too.
  2. Improving the observed trace in portable-lockdirs-no-solution.t so we can get a better failing observation. This should be able to see opam file reads are cached.
  3. Checking sat-solve-trace.t doesn't do any decisions or conflicts.

This should be all the coverage given by this test without having to endure the slow opam parsing.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants