Conversation
Signed-off-by: Arthur Wendling <arthur@tarides.com>
Alizter
requested changes
Sep 4, 2026
Alizter
left a comment
Collaborator
There was a problem hiding this comment.
While this is a cute example, I don't think we can afford having a monolithic test that takes 3s to run, especially if it isn't testing something directly. This test is doing some broad coverage and also acting as a benchmark. I think we should split this.
I would recommend:
- Extending
conflict-class.tto have a longer conflict class list perhaps with another package that shares an entry too. - Improving the observed trace in
portable-lockdirs-no-solution.tso we can get a better failing observation. This should be able to see opam file reads are cached. - Checking
sat-solve-trace.tdoesn't do any decisions or conflicts.
This should be all the coverage given by this test without having to endure the slow opam parsing.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Because it's there."