docs(ROADMAP): P1.12/P1.16 的 MetadataManagerPage 铺与 Total 计数按现实改写 (#3712) - #3732
Merged
Merged
Conversation
) #3704 / PR #3714 的围栏之外还剩两处同源漂移: 一、MetadataManagerPage 整片(:858 / :862 / :868 / :999)。该组件在 apps/console/src/ 下零文件零引用;`/system/metadata/:metadataType` 今天的 route element 是 MetadataRedirect,一跳转到 metadata-admin 引擎自己的 metadata/:type,元素为 MetadataResourceListPage (packages/app-shell/src/views/metadata-admin/ResourceListPage.tsx),由引擎的 MetadataResourceRegistry 驱动。:999 所指的 ObjectManagerListAdapter 与 listComponent 两个载体亦均零命中 —— object 根本不需要自定义列表,由 builtinComponents.tsx 的 registerMetadataResource({ type: 'object', … }) 接入通用外壳;引擎侧对应的插槽是 MetadataResourceConfig.ListPage,今天只有 datasource 覆写它。故连紧邻的 :1000(listComponent 判词的另一半)一并改写, 否则 :999 改完与它自相矛盾 —— 这正是分诊裁定要避免的形态。 二、:872 `Total: 20 system page tests passing`。「system page tests」无固定 指称(窄读 13、宽读 18,皆非 20),照 :871 / PR #3705 先例**不种新计数**, 改写为不含硬编码数字、并提示按需自行度量的表述。 手法沿用 #3700 / PR #3705:条目一律不删、就地按现实改写、原 [x] 保留(里程碑 确实以另一形态交付过)、错误名保留作纠错锚且判词紧跟其后、引用只挂裸文本编号、 不新增任何硬编码计数、不写版本号字面量。 围栏外另有 P1.12.3 / P1.16 的残余漂移(config/metadataTypeRegistry.ts、 listMode、MetadataGrid 等),按纪律只报不改,另立单。 Claude-Session: https://claude.ai/code/session_01GTRjn8xBqp75dk7kFupVRt Co-authored-by: Claude <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
yinlianghui
marked this pull request as ready for review
August 8, 2026 10:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3712
基线
origin/main@4e93e40d7(单据写的36bf20235已走远,分诊复核点0cf8f0f7亦已走远;四行的行号与内容在本取点仍逐字命中,详见下表)。仅改ROADMAP.md一个文件,6 增 6 删。一、前提复核(逐条,按裁定「读它引用的代码,别猜」)
/system/metadata/:metadataType→ MetadataManagerPageMetadataRedirect(apps/console/src/AppContent.tsx:190),一跳转到引擎自己的metadata/:type;MetadataManagerPage在apps/console/src/下零文件零引用(控制探针MetadataRedirect同路径 6 命中,扫描面正常)MetadataManagerPage列出任意已注册类型MetadataResourceListPage(packages/app-shell/src/views/metadata-admin/ResourceListPage.tsx),由引擎自己的MetadataResourceRegistry(同目录registry.ts)驱动,挂载在packages/app-shell/src/console/AppContent.tsx:641MetadataManagerPage与config/metadataTypeRegistry.ts随代码同去(两者均零命中);MetadataService*test*全仓零文件;SystemHubPage现存两套测的是它手写的两张卡(SystemHubPage.tsx:174-189注明 per-type 卡片已随引擎自动列举而移除),不是注册表生成的卡pages/system/__tests__/= 9 + 4 = 13,宽读併入AppContent.systemHubRoutes的 5 = 18,皆非 20 —— 单据的两个数字均复现ObjectManagerListAdapter经listComponent取代ObjectManagerPage确已删除(仅两处utils/metadataConverters.ts的陈旧 docblock 提及);但ObjectManagerListAdapter、listComponent、MetadataTypeConfig、MetadataDetailPage、pageSchemaFactory全仓零命中。object今天由引擎通用外壳列出,配置见packages/app-shell/src/services/builtinComponents.tsx:60的registerMetadataResource({ type: 'object', … }),不需要任何自定义列表组件结论:单据前提成立,且比标题所述更宽——:999 的两个「载体」名字都不存在,不只是换了实现。
二、越界一行,已声明:连改紧邻的 :1000
裁定的围栏是
:858 / :862 / :868 / :999。但 :1000 原文listComponent extension point on MetadataTypeConfig for injecting custom list UIs与 :999 是同一句话的后半、同一个零命中符号;只改 :999 会让它紧接着自相矛盾 —— 正是裁定第 1 条列为不可接受的形态。故一并改写,并在此明示越界范围为 ROADMAP.md 内 1 行。引擎侧的等价插槽是MetadataResourceConfig.ListPage(packages/app-shell/src/views/metadata-admin/registry.ts:116),今天只有datasource覆写它(datasource/register.ts:30)。三、:872 不种新计数
按裁定第 2 条与 :871 / PR #3705 先例:改写为不含硬编码数字的表述,并把「指称本身没定义」这件事写进条目本身、提示读者按需自行度量。没有写入 13,也没有写入 18 —— 种下 13 只是把同一个陷阱重新上膛。
四、手法(#3700 / PR #3705,裁定第 3 条)
条目一律不删;
[x]保留(里程碑确实以另一形态交付过,同 :866 audit-log 一行的处理);错误名保留作纠错锚、判词紧跟其后(同 PR #3714 对PermissionManagementPage的处理),便于日后 grep;引用只挂裸文本编号(#3639、#3712),不加 markdown 链接;全程零新增硬编码计数。五、门禁(裁定第 4 条,含版本号 prose 规则)
node scripts/check-control-bytes.mjs→OK (scanned 3686 tracked text file(s));另做超出门禁的自扫grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f]' ROADMAP.md→ 无命中,file ROADMAP.md仍报 UTF-8 text。node scripts/check-doc-links.mjs→Links are valid across 7 scan roots.。ROADMAP.md在该门禁的 disk 面上(scripts/check-doc-links.mjs:397),故本次改写只用裸文本编号、不新增任何链接。scripts/__tests__/doc-version-claims.test.ts:112的SCAN_ROOTS = ['content/docs', 'packages/*/README.md']——ROADMAP.md不在其扫描面上(即该门禁自述的「residual hole」)。仍按规则未写入任何版本号字面量,并实跑该测试确认绿:doc-version-claims.test.ts+check-doc-links.test.ts→Test Files 2 passed / Tests 88 passed。apps/console/src/pages/system/__tests__+AppContent.systemHubRoutes+AppContent.legacyRedirects→Test Files 4 passed / Tests 35 passed。六、Changeset:无
对齐 PR #3714 与 PR #3705 —— 两者的
--stat均只含ROADMAP.md、无.changeset/条目。ROADMAP.md是根级文档、不属任何发布包,无用户可见的包变更。check-changeset-fixed.mjs/check-changeset-no-major.mjs均绿。七、围栏外的残余(只报不改,另立单)
同两节里不属 MetadataManagerPage / listComponent 这一族的失实条目未动:P1.12.3 的 :861(
config/metadataTypeRegistry.ts零命中)、:863(注册表生成卡片)、:864(动态路由现为 legacy alias)、:866(object已无专属路由);:1001(入口统一到/system/metadata/object);以及 P1.16 的 Metadata Manager Grid Mode 整块 :987-:990(listMode、MetadataGrid全仓零命中)。Generated by Claude Code