Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This fork-only draft preserves the original NVIDIA/cuvs#2653 head at
f92d07a7d, before that work was synchronized with PR 2476 and reworked into nvzm123/cuvs#1.The archived branch is unchanged. This PR exists for historical inspection and comparison; it is not intended to merge.
Preserved work
BoundedParallelExecutor.writerThreadsbehavior.The exact archived delta is two commits and 19 files (
+1520/-120) relative to its original basee0f8a4eb4.Hardening scope
This snapshot hardens resources introduced by its graph-postprocessing path: a failed device-to-host copy closes the temporary host allocation and preserves a distinct close failure; successful staging copies and executors use scoped cleanup; serialization memory is bounded; and focused tests cover those behaviors.
It does not address the broader dataset-to-
CagraIndexownership issue later identified in PR 2476. The unquantized, binary, scalar, subset, single-vector, and upper-layer paths still retain their older tail-only cleanup behavior. A CAGRA build failure can therefore leave the input dataset unclosed, and a later graph/write failure can leave the index and its owned dataset unclosed.Relationship to current work
This snapshot predates and does not contain the current PR-2476 implementation. Fork PR #1 is the later synchronized version of the bounded graph materialization/serialization work. This archival PR is the appropriate place to inspect what the earlier PR-2653 head itself contained.