Repository navigation
fix: pass scoped globals to npm with forward slashes - #31
Merged
Merged
Conversation
nvm install --from rebuilt scoped package names via filepath.Join, so Windows produced @scope\name and npm treated it as a local path (ENOENT). Use npm's @scope/name form instead. Fixes nvm-windows/nvm#1537 Signed-off-by: coreybutler <770982+coreybutler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@scope/name(forward slash) ingetModuleList/listModulesAtWhy
nvm install --fromusedfilepath.Joinfor scoped package names, so Windows produced@scope\name. npm treats that as a local folder path and fails with ENOENT, marking the whole version install failed.Fixes nvm-windows/nvm#1537
Testing
go test ./installer -run TestListModulesAtScopedNamesUseSlashRisk
Low — naming fix for
--from/--copy-frommodule lists; FS paths still usefilepath.Join.