Repository navigation
test: firewall trust discovers pnpm.mjs launchers - #30
Merged
Merged
Conversation
Regression for NVM4306: findModuleLaunchers must return nested pnpm.mjs (and PNPM_HOME pnpm.mjs), not only pnpm.cmd, so trust resigns the entry proxy actually launches. Signed-off-by: Corey Butler <corey@author.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Regression tests that
findModuleLaunchers("pnpm")returns nestedpnpm.mjsandPNPM_HOME\bin\pnpm.mjs, not only.cmd.Why
NVM4306: trust that only resigned the wrapper left the real proxy entry unsigned.
Testing
go test ./commands/firewall -run FindModuleLaunchersIncludesPnpmRisk
None — test-only.