Repository navigation
fix: resign pnpm/yarn JS entrypoints on firewall trust - #29
Merged
Merged
Conversation
nvm firewall trust module previously re-signed only .cmd/.bat launchers. Proxy launches pnpm.mjs (and yarn.js/.cjs/.mjs), so trust left the real entrypoint unsigned and the next run hit NVM4306. Resign nested package-manager JS/CJS/MJS paths from PackageManagerCliRelPathsFor, plus standalone PNPM_HOME *.mjs/*.cjs/*.js. Signed-off-by: Corey Butler <corey@author.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Resign nested pnpm/yarn JS/CJS/MJS entrypoints (and standalone PNPM_HOME
*.mjs) whennvm firewall trust moduleruns — not only top-level.cmd/.bat.Why
Proxy prefers
pnpm.mjsover the cmd wrapper. Trust that only signedpnpm.cmdleft the real entrypoint unsigned → NVM4306 on next launch.Testing
PackageManagerCliRelPathsFor.pnpm --versionsucceeds.Risk
Low. Only expands which existing on-disk paths get
SignScriptafter an explicit trust action.