Repository navigation
fix: keep DataRoot under LocalAppData program home - #25
Merged
Merged
Conversation
Custom InstallRoot like D:\nvm made DataRoot=parent(InstallRoot)=D:\, so .shim/.nodejs spilled onto the drive root. DataRoot is always %LOCALAPPDATA%\Author Software\nvm (or programRootOverride in tests). Signed-off-by: Corey Butler <770982+coreybutler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DataRoot()always resolves under%LOCALAPPDATA%\Author Software\nvm(or testprogramRootOverride), neverparent(InstallRoot).D:\nvmcreatingD:\.shim,D:\.nodejs, etc. (Ai编写 v2.1.0-beta.6：数据根被推导成所选安装目录的父级 v2.1.0-beta.6: data root is derived as the parent of the chosen install directory (D:\nvm → D:\), so every command exits 1 with "runtime ACL hardening failed" nvm#1516).--repair/ doctor no longer treat InstallRoot parent as DataRoot; sandbox uses LocalAppData layout.Test plan
go test ./bootstrap/D:\nvm; confirm runtime dirs only under LocalAppData program homenvm use/ shim still resolve; noD:\.shim/D:\.nodejs