Add proactive stack overflow detection via MaxCallDepth + tests#317
Open
ModMaker101 wants to merge 1 commit into
Open
Add proactive stack overflow detection via MaxCallDepth + tests#317ModMaker101 wants to merge 1 commit into
ModMaker101 wants to merge 1 commit into
Conversation
Author
|
And solves #168. |
Author
|
@nuskey8 Mind reviewing this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds proactive stack overflow detection to prevent process terminating native
StackOverflowExceptionand enable sandboxing use.Changes
MaxCallDepthproperty to LuaState.CallandTailCallbefore pushing framesPushCallStackFramesto cover all the call sites.Tests:
Added the following:
ExceedingMaxCallDepth_ThrowsLuaRuntimeExceptionExceedingMaxCallDepth_WithPCall_ReturnsErrorMessageUnderMaxCallLimit_SucceedsDefaultMaxCallDepth_AllowsDeepRecursionAll tests passed. Ready for review.