Skip to content

tools: enable temporal by default in Nix integration - #66267

Merged
nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:nix-with-temporal
Sep 26, 2026
Merged

nodejs-github-bot merged 2 commits into
nodejs:mainfrom
aduh95:nix-with-temporal

Conversation

@aduh95

@aduh95 aduh95 commented Sep 24, 2026

Copy link
Copy Markdown
Contributor

So we can test it with test-shared.yml. Now that #62676 was fixed, it should "just work™"

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Sep 24, 2026
So we can test it with `test-shared.yml`.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
aduh95 requested a review from panva September 26, 2026 08:02
@panva panva added author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue PRs queued for automated landing through the Commit Queue. labels Sep 26, 2026
@aduh95
aduh95 requested a review from Renegade334 September 26, 2026 10:17
@aduh95 aduh95 added dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. labels Sep 26, 2026
@nodejs-github-bot
nodejs-github-bot merged commit 14e8f5b into nodejs:main Sep 26, 2026
48 of 49 checks passed
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Landed in 14e8f5b

@nodejs-github-bot nodejs-github-bot removed the commit-queue PRs queued for automated landing through the Commit Queue. label Sep 26, 2026
@aduh95
aduh95 deleted the nix-with-temporal branch September 26, 2026 22:58
aduh95 added a commit that referenced this pull request Sep 27, 2026
So we can test it with `test-shared.yml`.

Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #66267
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. dont-land-on-v22.x PRs that should not land on the v22.x-staging branch and should not be released in v22.x. dont-land-on-v24.x PRs that should not land on the v24.x-staging branch and should not be released in v24.x. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants