Skip to content

build: port make_temporal_zoneinfo_cpp to GYP #66183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aduh95 wants to merge 1 commit into
base: main
Choose a base branch
from
+25 −0
Open

build: port make_temporal_zoneinfo_cpp to GYP #66183

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions tools/v8_gypfiles/v8.gyp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1161,6 +1161,31 @@
'../../deps/crates/crates.gyp:temporal_capi',
],
}],
['v8_enable_i18n_support==0', {
'sources': [
'<(SHARED_INTERMEDIATE_DIR)/src/builtins/builtins-temporal-zoneinfo64-data.cc',
],
'actions': [
{
'action_name': 'make_temporal_zoneinfo_cpp',
'inputs': [
'<(V8_ROOT)/tools/include-file-as-bytes.py',
'../../deps/crates/vendor/zoneinfo64-v0_3/src/data/zoneinfo64.res',

@Renegade334 Renegade334 Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path may change after git node v8 major if zoneinfo64 receives a version bump in the Rust deps.

Also, will this fail in the case where a slim tarball is being used with shared Temporal?

@aduh95 aduh95 Sep 21, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This path may change after git node v8 major if zoneinfo64 receives a version bump in the Rust deps.

Sure, in this case the path would need to be updated. Are you saying that so we take some preemptive action?

Also, will this fail in the case where a slim tarball is being used with shared Temporal?

Probably, worth noting that slim tarball is not something we distribute, and that limits what build flag can be used (e.g. you have to pass a bunch of --shared-• flags), so it's not really a concern to break that IMO. What would be alternative anyway?

@Renegade334 Renegade334 Sep 21, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, in this case the path would need to be updated. Are you saying that so we take some preemptive action?

Just thinking in terms of maintainer quality of life, that's all – we automated this in crates.gyp as part of the upgrade process, might be worth thinking about.

The other thing is that the bundled .res with the zoneinfo64 crate is advertised as for testing only – it's probably fine, but there are no promises that it'll be kept up-to-date. An alternative would be using the ICU source itself, much as GN does, eg. 3d85ecd.

],
'outputs': [
'<(SHARED_INTERMEDIATE_DIR)/src/builtins/builtins-temporal-zoneinfo64-data.cc',
],
'action': [
'<(python)',
'<(V8_ROOT)/tools/include-file-as-bytes.py',
'../../deps/crates/vendor/zoneinfo64-v0_3/src/data/zoneinfo64.res',
'<@(_outputs)',
'zoneinfo64_static_data',
],
'message': 'Generating zoneinfo64 static data for Temporal',
},
],
}],
],
'sources': [
'<!@pymod_do_main(GN-scraper "<(V8_ROOT)/BUILD.gn" "\\"v8_base_without_compiler.*?v8_enable_temporal_support.*?sources \\+= ")',
Expand Down
Loading