Conversation
anonrig
marked this pull request as ready for review
September 21, 2026 04:16
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
cursor
Bot
force-pushed
the
cursor/net-blocklist-fast-ead2
branch
4 times, most recently
from
September 21, 2026 05:23
e010e5d to
f7a2973
Compare
Skip toLowerCase() for the documented ipv4/ipv6 families and add a V8 Fast API for one-byte address strings. The FastOneByteString callback takes FastApiCallbackOptions so V8 can use the fast path reliably (required for string-shaped Fast API arguments). Overlong IPv6 zone ids are parsed like uv_ip6_addr (unknown zone is scope_id 0; address parts 40+ chars stay a miss). IPv4 zone suffixes stay a miss, matching uv_ip4_addr. Assisted-by: a closed-source coding agent Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
cursor
Bot
force-pushed
the
cursor/net-blocklist-fast-ead2
branch
from
September 21, 2026 05:28
f7a2973 to
8af2ba0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #66166 +/- ##
==========================================
+ Coverage 90.27% 90.28% +0.01%
==========================================
Files 790 790
Lines 271651 272077 +426
Branches 51842 51947 +105
==========================================
+ Hits 245228 245647 +419
- Misses 16928 16938 +10
+ Partials 9495 9492 -3
🚀 New features to boost your workflow:
|
jasnell
approved these changes
Sep 21, 2026
anonrig
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
pimterry
approved these changes
Sep 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
net.BlockList.check(string)always lowercased the family and went through the slowcheckStringC++ binding. The documented families areipv4/ipv6, so skiptoLowerCase()for those, and add a V8 Fast API for one-byte address strings (no heap allocation; stack-copy +uv_ip*_addr).SocketAddress
check()(already Fast API) is unchanged.This change was implemented with assistance from a closed-source coding agent. I verified the source, official
benchmark/net/net-blocklist.jsresults, andtest-blocklist.js/test-blocklist-fast-api.js/test-net-blocklist.js.Official benches
Three-run medians,
n=1e6,operation=check,ruleType=address:checkhitruleCount=10checkhitruleCount=1000checkmissruleCount=10checkWithSocketAddresshitruleCount=10Tests
test-blocklist.js,test-blocklist-fast-api.js,test-net-blocklist.js.