Skip to content

test: improve sequential test performance - #65928

Open
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/sequential-test-fixes
Open

test: improve sequential test performance#65928
jasnell wants to merge 1 commit into
nodejs:mainfrom
jasnell:jasnell/sequential-test-fixes

Conversation

@jasnell

@jasnell jasnell commented Sep 9, 2026

Copy link
Copy Markdown
Member

Make a couple of sequential tests clean up eagerly to reduce runtime. Potentially saves in the range of 5-12 seconds per run on some CI jobs.

@jasnell
jasnell requested review from aduh95 and mcollina September 9, 2026 06:04
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure. labels Sep 9, 2026
@codecov

codecov Bot commented Sep 9, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.18%. Comparing base (0de4fcc) to head (6005dd5).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #65928      +/-   ##
==========================================
+ Coverage   90.17%   90.18%   +0.01%     
==========================================
  Files         771      771              
  Lines      265470   265470              
  Branches    50463    50460       -3     
==========================================
+ Hits       239383   239412      +29     
+ Misses      17055    17003      -52     
- Partials     9032     9055      +23     

see 35 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@jasnell
jasnell requested a review from codebytere September 9, 2026 13:35
Comment thread test/sequential/test-net-connect-econnrefused.js Outdated
Comment thread test/sequential/test-net-connect-econnrefused.js Outdated
@jasnell
jasnell force-pushed the jasnell/sequential-test-fixes branch from e52279d to 9f71ba0 Compare September 10, 2026 20:56
Make a couple of sequential tests clean up eagerly
to reduce runtime.

Signed-off-by: James M Snell <jasnell@gmail.com>
Assisted-by: Opencode
@jasnell
jasnell force-pushed the jasnell/sequential-test-fixes branch from 9f71ba0 to 6005dd5 Compare September 10, 2026 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. test Issues and PRs related to Node.js core tests and test infrastructure.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants