buffer: fix unaligned UTF-16LE decoding - #65905
Open
mcollina wants to merge 1 commit into
Open
Conversation
For odd-length input, the destination only has room for complete code units. Copy those units and ignore the trailing byte. This matches the aligned and big-endian paths. Assisted-by: pi Signed-off-by: Matteo Collina <hello@matteocollina.com>
nodejs-github-bot
added
buffer
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #65905 +/- ##
==========================================
- Coverage 90.18% 90.17% -0.02%
==========================================
Files 771 771
Lines 264911 265097 +186
Branches 50309 50353 +44
==========================================
+ Hits 238919 239046 +127
- Misses 16966 17005 +39
- Partials 9026 9046 +20
🚀 New features to boost your workflow:
|
gurgunday
added
the
request-ci
github-actions
Bot
removed
the
request-ci
Collaborator
panva
approved these changes
Sep 8, 2026
panva
added
the
author ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
Buffer.prototype.toString()decoded unaligned UTF-16LE input with an odd byte length, the temporary destination was sized for complete code units while the copy included the trailing byte.Copy only complete code units, matching the aligned and big-endian paths. Add coverage for stack-backed and heap-backed temporary buffers.